From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Xie XiuQi <xiexiuqi@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
josh@joshtriplett.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, laijs@cn.fujitsu.com,
corbet@lwn.net, mingo@kernel.org
Subject: Re: [PATCH] documentation: Update sysfs path for rcu_cpu_stall_timeout
Date: Mon, 10 Nov 2014 20:08:36 -0800 [thread overview]
Message-ID: <20141111040836.GT4901@linux.vnet.ibm.com> (raw)
In-Reply-To: <1415678606-28216-1-git-send-email-xiexiuqi@huawei.com>
On Tue, Nov 11, 2014 at 12:03:26PM +0800, Xie XiuQi wrote:
> Commit 6bfc09e2327d ("rcu: Provide RCU CPU stall warnings for tiny RCU")
> moved the rcu_cpu_stall_timeout module parameter from rcutree.c to
> rcupdate.c, but failed to update Documentation/RCU/stallwarn.txt. This
> commit therefore repairs this omission.
>
> commit 96224daa16d6 ("documentation: Update sysfs path for rcu_cpu_stall_suppress")
> updated the path for rcu_cpu_stall_suppress, but failed to update for
> rcu_cpu_stall_timeout.
>
> Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
Good catch, thank you! Queued for 3.20.
Thanx, Paul
> ---
> Documentation/RCU/stallwarn.txt | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/RCU/stallwarn.txt b/Documentation/RCU/stallwarn.txt
> index ef5a2fd..da6a801 100644
> --- a/Documentation/RCU/stallwarn.txt
> +++ b/Documentation/RCU/stallwarn.txt
> @@ -15,7 +15,7 @@ CONFIG_RCU_CPU_STALL_TIMEOUT
> 21 seconds.
>
> This configuration parameter may be changed at runtime via the
> - /sys/module/rcutree/parameters/rcu_cpu_stall_timeout, however
> + /sys/module/rcupdate/parameters/rcu_cpu_stall_timeout, however
> this parameter is checked only at the beginning of a cycle.
> So if you are 10 seconds into a 40-second stall, setting this
> sysfs parameter to (say) five will shorten the timeout for the
> --
> 1.7.1
>
prev parent reply other threads:[~2014-11-11 4:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 4:03 Xie XiuQi
2014-11-11 4:08 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111040836.GT4901@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=corbet@lwn.net \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome