From: "Luis Claudio R. Goncalves" <lclaudio@uudg.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Clark Williams <clark.williams@gmail.com>
Subject: [PATCH] ftrace: fix traceoff_on_warning handling on boot command line
Date: Wed, 12 Nov 2014 21:14:00 -0200 [thread overview]
Message-ID: <20141112231400.GL12281@uudg.org> (raw)
Steven,
While backporting traceoff_on_warning to 3.10.33-rt we noticed a slightly
difference between what was stated on Documentation/kernel-parameters.txt
and the actual code.
Please consider the following patch for inclusion.
Best regards,
Luis
------
ftrace: fix traceoff_on_warning handling on boot command line
According to the documentation, adding "traceoff_on_warning" to the boot
command line should be enough to enable the feature. But right now it is
necessary to specify "traceoff_on_warning=". Along with fixing that, also
verify if the value passed, if any, is either "0" or "off".
Signed-off-by: Luis Claudio R. Goncalves <lgoncalv@redhat.com>
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index f68981f..a956a60 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -155,10 +155,11 @@ __setup("ftrace_dump_on_oops", set_ftrace_dump_on_oops);
static int __init stop_trace_on_warning(char *str)
{
- __disable_trace_on_warning = 1;
+ if ((strcmp(str, "=0") != 0 && strcmp(str, "=off") != 0))
+ __disable_trace_on_warning = 1;
return 1;
}
-__setup("traceoff_on_warning=", stop_trace_on_warning);
+__setup("traceoff_on_warning", stop_trace_on_warning);
static int __init boot_alloc_snapshot(char *str)
{
next reply other threads:[~2014-11-12 23:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 23:14 Luis Claudio R. Goncalves [this message]
2014-11-12 23:42 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112231400.GL12281@uudg.org \
--to=lclaudio@uudg.org \
--cc=clark.williams@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®