From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934228AbaKMTga (ORCPT ); Thu, 13 Nov 2014 14:36:30 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:58678 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933690AbaKMTfx (ORCPT ); Thu, 13 Nov 2014 14:35:53 -0500 Date: Thu, 13 Nov 2014 14:35:51 -0500 (EST) Message-Id: <20141113.143551.1032729786667755501.davem@davemloft.net> To: herbert@gondor.apana.org.au Cc: jasowang@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com Subject: Re: [PATCH net-next] tun: fix issues of iovec iterators using in tun_put_user() From: David Miller In-Reply-To: <20141113085838.GA3070@gondor.apana.org.au> References: <1415868854-4913-1-git-send-email-jasowang@redhat.com> <20141113085838.GA3070@gondor.apana.org.au> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Thu, 13 Nov 2014 11:35:52 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Herbert Xu Date: Thu, 13 Nov 2014 16:58:38 +0800 > On Thu, Nov 13, 2014 at 04:54:14PM +0800, Jason Wang wrote: >> This patch fixes two issues after using iovec iterators: >> - vlan_offset should be initialized to zero, otherwise unexpected offset >> will be used in skb_copy_datagram_iter() >> - advance iovec iterator when vnet_hdr_sz is greater than sizeof(gso), this >> is the case when mergeable rx buffer were enabled for a virt guest. >> >> Fixes e0b46d0ee9c240c7430a47e9b0365674d4a04522 ("tun: Use iovec iterators") >> Cc: Herbert Xu >> Signed-off-by: Jason Wang > > Good catch. > > Acked-by: Herbert Xu Applied, thanks everyone.