From: Mark Brown <broonie@kernel.org>
To: Andrew Bresticker <abrestic@chromium.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
James Hartley <James.Hartley@imgtec.com>,
Ezequiel Garcia <Ezequiel.Garcia@imgtec.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH V2 2/2] spi: Add driver for IMG SPFI controller
Date: Thu, 13 Nov 2014 17:44:05 +0000 [thread overview]
Message-ID: <20141113174405.GJ3815@sirena.org.uk> (raw)
In-Reply-To: <1415848096-20079-3-git-send-email-abrestic@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 532 bytes --]
On Wed, Nov 12, 2014 at 07:08:16PM -0800, Andrew Bresticker wrote:
> +#ifdef CONFIG_PM_SLEEP
> +static int img_spfi_suspend(struct device *dev)
> +{
> + struct spi_master *master = dev_get_drvdata(dev);
> +
> + return spi_master_suspend(master);
> +}
This should really be checking that the device is runtime suspended and
disabling the clocks if not, if nothing else someone might be running
with !CONFIG_RUNTIME_PM.
One of these days we'll get runtime and system PM playing more
frictionlessly but not today.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-13 17:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 3:08 [PATCH V2 0/2] spi: IMG SPFI driver Andrew Bresticker
2014-11-13 3:08 ` [PATCH V2 1/2] spi: Add binding document for IMG SPFI controller Andrew Bresticker
2014-11-13 3:08 ` [PATCH V2 2/2] spi: Add driver " Andrew Bresticker
2014-11-13 17:44 ` Mark Brown [this message]
2014-11-13 17:36 ` [PATCH V2 0/2] spi: IMG SPFI driver Mark Brown
2014-11-14 15:04 ` Mark Brown
2014-11-14 18:46 ` Andrew Bresticker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113174405.GJ3815@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Ezequiel.Garcia@imgtec.com \
--cc=James.Hartley@imgtec.com \
--cc=abrestic@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®