Re: [PATCH vfs 1/2] lib: implement ptrset

[Tejun Heo <tj@kernel.org>]

Hello, Andrew.

On Thu, Nov 13, 2014 at 02:40:41PM -0800, Andrew Morton wrote:
> In that case tjpointer_add() would need to do a kmalloc() for each inode
> which is added to the bdev/cdev, just as ptrset_add() is doing.
> 
> That might require a nasty preload thing.  But really, for just two
> known callers it would be better to require the caller to create the
> storage.
> 
> 
> 	struct tjpointer *new_tpj;
> 
> 	new_tpj = kmalloc(...);
> 	lock();
> 	tjpointer_add(&my_tjp_list, new_tjp, my_pointer);
> 	unlock();
> 
> Basically what I'm saying is nuke the rbtree and use lists.

Hah?  Then, each removal would be O(N) where N is the number of total
block devices and there are cases where massive number of block
devices exist and many are added / removed back-to-back.  I don't
think making those operations O(N^2) is a good idea.

Thanks.

-- 
tejun