From: Andi Kleen <andi@firstfloor.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>, Jiri Olsa <jolsa@kernel.org>,
linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
"Liang, Kan" <kan.liang@intel.com>
Subject: Re: Implement lbr-as-callgraph v10
Date: Tue, 18 Nov 2014 02:56:14 +0100 [thread overview]
Message-ID: <20141118015614.GE12538@two.firstfloor.org> (raw)
In-Reply-To: <20141117213457.GE4163@kernel.org>
On Mon, Nov 17, 2014 at 06:34:57PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Nov 12, 2014 at 06:05:18PM -0800, Andi Kleen escreveu:
> > [Reworks to address all the review feedback. Rebased to latest tree]
> > [Just a repost after a rebase]
> > [Even more review feedback and some bugs addressed.]
> > [Only port to changes in perf/core. No other changes.]
> > [Rebase to latest perf/core]
> > [Another rebase. No changes]
> >
> > This patchkit implements lbr-as-callgraphs in per freport,
> > as an alternative way to present LBR information.
>
> Ok, I have this in my perf/core branch, but I need to test it further,
> as I couldn't get the output that appears on some of the changelogs.
>
> If you could take a look at
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf/core
>
> To see if I made some mistake, that would be of help,
Sorry the CCKEY_ADDRESS hunk was actually needed. With that I get
the srclines as expected.
Also the BUILD_BUG_ON change breaks the compilation with optimization
off (DEBUG=1). I'll send patches for both.
Also please consider the adding the symbol offset fix patch
I sent Friday.
-Andi
next prev parent reply other threads:[~2014-11-18 1:56 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 2:05 Andi Kleen
2014-11-13 2:05 ` [PATCH 01/10] perf, tools: Factor out adding new call chain entries Andi Kleen
2014-11-13 19:14 ` Arnaldo Carvalho de Melo
2014-11-20 7:37 ` [tip:perf/core] perf callchain: " tip-bot for Andi Kleen
2014-11-13 2:05 ` [PATCH 02/10] perf, tools: Support handling complete branch stacks as histograms Andi Kleen
2014-11-13 19:14 ` Arnaldo Carvalho de Melo
2014-11-13 19:52 ` Andi Kleen
2014-11-13 20:08 ` Arnaldo Carvalho de Melo
2014-11-13 20:15 ` Andi Kleen
2014-11-13 20:42 ` Arnaldo Carvalho de Melo
2014-12-08 6:53 ` [tip:perf/core] perf callchain: " tip-bot for Andi Kleen
2014-11-13 2:05 ` [PATCH 03/10] perf, tools: Use al.addr to set up call chain Andi Kleen
2014-11-13 19:16 ` Arnaldo Carvalho de Melo
2014-12-11 21:46 ` Jiri Olsa
2014-12-11 22:27 ` Andi Kleen
2014-11-20 7:38 ` [tip:perf/core] perf callchain: " tip-bot for Andi Kleen
2014-11-13 2:05 ` [PATCH 04/10] perf, tools: Add --branch-history option to report Andi Kleen
2014-12-08 6:53 ` [tip:perf/core] perf report: Add --branch-history option tip-bot for Andi Kleen
2014-11-13 2:05 ` [PATCH 05/10] perf, tools: Use a common function to resolve symbol or name Andi Kleen
2014-11-13 19:17 ` Arnaldo Carvalho de Melo
2014-11-20 7:38 ` [tip:perf/core] perf callchain: " tip-bot for Andi Kleen
2014-11-13 2:05 ` [PATCH 06/10] perf, tools: Enable printing the srcline in the history Andi Kleen
2014-11-13 19:20 ` Arnaldo Carvalho de Melo
2014-12-08 6:48 ` [tip:perf/core] perf callchain: " tip-bot for Andi Kleen
2014-11-13 2:05 ` [PATCH 07/10] perf, tools: Only print base source file for srcline Andi Kleen
2014-11-13 19:22 ` Arnaldo Carvalho de Melo
2014-11-20 7:38 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2014-11-13 2:05 ` [PATCH 08/10] perf, tools: Support source line numbers in annotate Andi Kleen
2014-11-13 20:52 ` Arnaldo Carvalho de Melo
2014-11-20 7:39 ` [tip:perf/core] perf annotate: " tip-bot for Andi Kleen
2014-11-13 2:05 ` [PATCH 09/10] tools, perf: Make get_srcline fall back to sym+offset Andi Kleen
2014-12-08 6:49 ` [tip:perf/core] perf callchain: " tip-bot for Andi Kleen
2014-11-13 2:05 ` [PATCH 10/10] tools, perf: Add asprintf replacement Andi Kleen
2014-11-13 20:53 ` Arnaldo Carvalho de Melo
2014-11-13 21:14 ` Andi Kleen
2014-11-17 21:34 ` Implement lbr-as-callgraph v10 Arnaldo Carvalho de Melo
2014-11-18 1:56 ` Andi Kleen [this message]
2014-11-18 10:44 ` Jiri Olsa
2014-11-18 11:00 ` Jiri Olsa
2014-11-18 13:37 ` Arnaldo Carvalho de Melo
2014-11-19 15:31 ` Andi Kleen
2014-11-19 6:21 ` Namhyung Kim
2014-11-19 9:23 ` Jiri Olsa
2014-11-19 10:54 ` Jiri Olsa
2014-11-19 14:10 ` Arnaldo Carvalho de Melo
2014-11-19 16:04 ` Arnaldo Carvalho de Melo
2014-11-19 21:48 ` Andi Kleen
2014-11-20 19:33 ` Arnaldo Carvalho de Melo
2014-11-20 20:46 ` Andi Kleen
2014-11-21 20:30 ` Arnaldo Carvalho de Melo
2014-11-22 1:25 ` Andi Kleen
2014-11-24 7:40 ` Namhyung Kim
2014-11-19 21:50 ` Andi Kleen
2014-11-20 20:36 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2014-09-26 23:37 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118015614.GE12538@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome