From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
Lee Jones <lee.jones@linaro.org>,
linus.walleij@linaro.org, gnurou@gmail.com,
alsa-devel@alsa-project.org, tiwai@suse.de,
patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/3] mfd: arizona: Add support for CS47L24
Date: Tue, 18 Nov 2014 15:00:39 +0000 [thread overview]
Message-ID: <20141118150039.GO22111@sirena.org.uk> (raw)
In-Reply-To: <20141117151318.GE12443@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]
On Mon, Nov 17, 2014 at 03:13:18PM +0000, Charles Keepax wrote:
> 1) We could add #defines for various IP blocks and the readable
> callback could include these defines for various blocks. Which
> would reduce the duplication between chips. Although a lot of the
> blocks have small differences between chips which might hurt some
> of the benefits and this does also have some negative affects on the
> greppability of it all. This could also be done as functions then
> some of the differences could be taken into account locally for
> each block but that hurts the performance and probably
> readability.
I don't follow this suggestion, sorry.
> 2) We could add a function to the regmap core that makes any
> register with a default or marked as volatile readable. That
> would remove the readable callback completely and not really hurt
> greppability (assuming we could change the default array to use
> the #defines for the register) but at fairly large runtime cost.
> We would have to search the default array everytime we wanted to
> check if a register is readable.
This sounds far too expensive at runtime, especially for large register
sets. You can do tables of ranges but that's much more efficient since
the expecation is that if you're using that there's an order of
magnitude size difference.
Honestly I'm not sure I see a big problem with the large tables; they're
large but not hard to think about, from my point of view large blocks of
code are scary but large blocks of data, meh.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-18 15:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 16:52 [PATCH 0/3] Driver for Cirrus Logic CS47L24 codec Richard Fitzgerald
2014-11-11 17:03 ` [PATCH 1/3] mfd: arizona: Add support for CS47L24 Richard Fitzgerald
2014-11-12 9:34 ` Charles Keepax
2014-11-11 17:04 ` [PATCH 2/3] gpio: " Richard Fitzgerald
2014-11-11 17:16 ` Mark Brown
2014-11-17 6:41 ` Linus Walleij
2014-11-17 9:58 ` Richard Fitzgerald
2014-11-17 15:03 ` Mark Brown
2014-11-11 17:05 ` [PATCH 3/3] ASoC: arizona: Add initial CS47L24 codec driver Richard Fitzgerald
2014-11-18 14:51 ` Mark Brown
2014-11-18 17:34 ` Richard Fitzgerald
2014-11-11 17:15 ` [PATCH 1/3] mfd: arizona: Add support for CS47L24 Richard Fitzgerald
2014-11-13 10:12 ` Lee Jones
2014-11-13 16:24 ` Richard Fitzgerald
2014-11-13 16:40 ` Charles Keepax
2014-11-17 12:16 ` Lee Jones
2014-11-17 12:54 ` Richard Fitzgerald
2014-11-17 15:01 ` Mark Brown
2014-11-18 11:34 ` Lee Jones
2014-11-18 13:10 ` Richard Fitzgerald
2014-11-17 15:13 ` Charles Keepax
2014-11-18 15:00 ` Mark Brown [this message]
2014-11-19 16:51 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118150039.GO22111@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=gnurou@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®