From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Lee Jones <lee.jones@linaro.org>,
Doug Anderson <dianders@chromium.org>,
Bill Richardson <wfrichar@chromium.org>,
Olof Johansson <olof@lixom.net>, Simon Glass <sjg@google.com>,
Gwendal Grignou <gwendal@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mfd: cros_ec: Add Chrome OS EC userspace device interface
Date: Tue, 18 Nov 2014 17:00:01 +0000 [thread overview]
Message-ID: <20141118170001.6256c6df@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1416238213-15263-2-git-send-email-javier.martinez@collabora.co.uk>
> +#ifdef CONFIG_COMPAT
> +struct compat_cros_ec_command {
> + uint32_t version;
> + uint32_t command;
> + compat_uptr_t outdata;
> + uint32_t outsize;
> + compat_uptr_t indata;
> + uint32_t insize;
> + uint32_t result;
> +};
> +
> +struct compat_cros_ec_readmem {
> + uint32_t offset;
> + uint32_t bytes;
> + compat_uptr_t buffer;
> +};
>
This is a new API - arrange them to be 64bit safe and properly padded,
there is no excuse for needing compat crap except for legacy interfaces
you can't fix.
Alan
next prev parent reply other threads:[~2014-11-18 17:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 15:30 [PATCH 0/3] mfd: cros_ec: Add user-space dev inferface support Javier Martinez Canillas
2014-11-17 15:30 ` [PATCH 1/3] mfd: cros_ec: Add Chrome OS EC userspace device interface Javier Martinez Canillas
2014-11-18 14:18 ` Lee Jones
2014-11-20 11:27 ` Javier Martinez Canillas
2014-11-20 11:58 ` Lee Jones
2014-11-20 12:13 ` Javier Martinez Canillas
2014-11-20 13:26 ` Lee Jones
2014-11-18 17:00 ` One Thousand Gnomes [this message]
2014-11-19 18:37 ` Javier Martinez Canillas
2014-11-19 20:45 ` Olof Johansson
2014-11-20 10:03 ` Javier Martinez Canillas
2014-11-17 15:30 ` [PATCH 2/3] mfd: cros_ec: Create sysfs attributes for the ChromeOS EC Javier Martinez Canillas
2014-11-18 14:26 ` Lee Jones
2014-11-20 11:58 ` Javier Martinez Canillas
2014-11-20 18:16 ` Bill Richardson
2014-11-21 18:40 ` Javier Martinez Canillas
2014-11-17 15:30 ` [PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users Javier Martinez Canillas
2014-11-18 14:22 ` Lee Jones
2014-11-20 12:00 ` Javier Martinez Canillas
2014-11-20 13:27 ` Lee Jones
2014-11-20 13:36 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118170001.6256c6df@lxorguk.ukuu.org.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=dianders@chromium.org \
--cc=gwendal@google.com \
--cc=javier.martinez@collabora.co.uk \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sjg@google.com \
--cc=wfrichar@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®