mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: joestringer@nicira.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	pshelar@nicira.com, dev@openvswitch.org
Subject: Re: [PATCH net] openvswitch: Fix mask generation for IPv6 labels.
Date: Wed, 19 Nov 2014 15:19:48 -0500 (EST)	[thread overview]
Message-ID: <20141119.151948.1499529626052606712.davem@davemloft.net> (raw)
In-Reply-To: <1416336857-61405-1-git-send-email-joestringer@nicira.com>

From: Joe Stringer <joestringer@nicira.com>
Date: Tue, 18 Nov 2014 10:54:17 -0800

> When userspace doesn't provide a mask, OVS datapath generates a fully
> unwildcarded mask for the flow. This is done by taking a copy of the
> flow key, then iterating across its attributes, setting all values to
> 0xff. This works for most attributes, as the length of the netlink
> attribute typically matches the length of the value. However, IPv6
> labels only use the lower 20 bits of the field. This patch makes a
> special case to handle this.
> 
> This fixes the following error seen when installing IPv6 flows without a mask:
> 
> openvswitch: netlink: Invalid IPv6 flow label value (value=ffffffff, max=fffff)
> 
> Signed-off-by: Joe Stringer <joestringer@nicira.com>

Judging by the discussion ongoing about this patch, I am assuming there
will be a new version of this change forthcoming.

Thanks.

      parent reply	other threads:[~2014-11-19 20:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18 18:54 Joe Stringer
2014-11-19  6:09 ` Pravin Shelar
     [not found]   ` <CAOftzPgYBBFTfNZunf4oGSmECzjOKF0=dnQ9EkTDFsDi+9jfNw@mail.gmail.com>
2014-11-19  8:11     ` [ovs-dev] " Pravin Shelar
2014-11-19 17:48       ` Joe Stringer
2014-11-19 19:08         ` Pravin Shelar
2014-11-19 19:51           ` Joe Stringer
2014-11-19 20:33             ` Pravin Shelar
2014-11-19 20:49               ` Joe Stringer
2014-11-19 20:19 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141119.151948.1499529626052606712.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=joestringer@nicira.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®