From: Mark Brown <broonie@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Simon Glass <sjg@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Olof Johansson <olof@lixom.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] ARM: dts: Add SPI flash node for Peach boards
Date: Wed, 19 Nov 2014 17:47:09 +0000 [thread overview]
Message-ID: <20141119174709.GF22111@sirena.org.uk> (raw)
In-Reply-To: <CAD=FV=XpweHvcTsVTMBkv9g4+GxoO8WdngGhfVj0QnOwq3ASdQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On Wed, Nov 19, 2014 at 09:19:13AM -0800, Doug Anderson wrote:
Please stop CCing my work address for upstream things.
> On Wed, Nov 19, 2014 at 2:07 AM, Javier Martinez Canillas
> > I see, I thought that it was a common practice in the mainline kernel
> > too since I saw that many board DTS currently have a spidev node:
> > $ git grep 'compatible = "spidev"' arch/arm/boot/dts/ | wc -l
> > 19
These are bugs. The device tree should describe the hardware, spidev is
a Linux implementation detail. Provide a compatible string for the
device that is there just as you would for any other device.
> OK. Please don't take my comments as a NAK on this patch. I should
> have done the same grep myself before sending--sorry. I just
> remembered the old conversation and looked for that instead.
Please take this as one.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-19 17:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 17:43 [PATCH 0/3] ARM: dts: Add spidev nodes for Exynos Chromebooks Javier Martinez Canillas
2014-11-17 17:43 ` [PATCH 1/3] ARM: dts: Add SPI flash node for Peach boards Javier Martinez Canillas
2014-11-18 17:50 ` Doug Anderson
2014-11-19 10:07 ` Javier Martinez Canillas
2014-11-19 17:19 ` Doug Anderson
2014-11-19 17:29 ` Javier Martinez Canillas
2014-11-19 17:47 ` Mark Brown [this message]
2014-11-19 17:59 ` Javier Martinez Canillas
2014-11-17 17:43 ` [PATCH 2/3] ARM: dts: Add spidev registration to exynos5250-snow Javier Martinez Canillas
2014-11-17 17:43 ` [PATCH 3/3] ARM: exynos_defconfig: Enable user mode SPI device support Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119174709.GF22111@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sjg@chromium.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome