From: Andi Kleen <andi@firstfloor.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
Borislav Petkov <bp@alien8.de>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Oleg Nesterov <oleg@redhat.com>, Tony Luck <tony.luck@intel.com>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH v3 3/3] sched, x86: Check that we're on the right stack in schedule and __might_sleep
Date: Wed, 19 Nov 2014 20:29:28 +0100 [thread overview]
Message-ID: <20141119192928.GL12538@two.firstfloor.org> (raw)
In-Reply-To: <CA+55aFztsw6Vt4CyVs1OsqdKXxQmFrxHdE7z89VMZ_1KwKPcmQ@mail.gmail.com>
On Wed, Nov 19, 2014 at 10:40:10AM -0800, Linus Torvalds wrote:
> On Tue, Nov 18, 2014 at 3:15 PM, Andy Lutomirski <luto@amacapital.net> wrote:
> > On x86, sleeping while on an IST or irq stack has a surprisingly
> > good chance of working, but it can also fail dramatically. Add an
> > arch hook to allow schedule and __might_sleep to catch sleeping on
> > the wrong stack.
>
> Why doesn't the normal in_interrupt() test catch this?
The exception handlers which use the IST stacks don't necessarily
set irq count. Maybe they should.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2014-11-19 19:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 23:15 [PATCH v3 0/3] Handle IST interrupts from userspace on the normal stack Andy Lutomirski
2014-11-18 23:15 ` [PATCH v3 1/3] uprobes, x86: Fix _TIF_UPROBE vs _TIF_NOTIFY_RESUME Andy Lutomirski
2014-11-18 23:15 ` [PATCH v3 2/3] x86, entry: Switch stacks on a paranoid entry from userspace Andy Lutomirski
2014-11-18 23:15 ` [PATCH v3 3/3] sched, x86: Check that we're on the right stack in schedule and __might_sleep Andy Lutomirski
2014-11-19 18:40 ` Linus Torvalds
2014-11-19 19:23 ` Andy Lutomirski
2014-11-19 19:29 ` Andi Kleen [this message]
2014-11-19 19:44 ` Linus Torvalds
2014-11-19 23:04 ` Andy Lutomirski
2014-11-19 23:23 ` Linus Torvalds
2014-11-19 23:32 ` Thomas Gleixner
2014-11-19 23:42 ` Linus Torvalds
2014-11-19 23:49 ` Andy Lutomirski
2014-11-19 23:59 ` Linus Torvalds
2014-11-20 0:13 ` Andy Lutomirski
2014-11-20 0:37 ` Linus Torvalds
2014-11-20 0:46 ` Andy Lutomirski
2014-11-20 1:09 ` Linus Torvalds
2014-11-20 1:11 ` Andy Lutomirski
2014-11-20 10:28 ` Borislav Petkov
2014-11-20 23:25 ` Andy Lutomirski
2014-11-20 7:45 ` Ingo Molnar
2016-02-29 5:27 ` Andy Lutomirski
2016-05-24 1:23 ` Andy Lutomirski
2016-05-24 1:48 ` Linus Torvalds
2016-05-24 2:09 ` Andy Lutomirski
2016-05-24 2:16 ` Linus Torvalds
2014-11-19 18:29 ` [PATCH v3 0/3] Handle IST interrupts from userspace on the normal stack Luck, Tony
2014-11-19 22:15 ` [PATCH] x86, mce: Get rid of TIF_MCE_NOTIFY and associated mce tricks Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119192928.GL12538@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome