From: Steven Rostedt <rostedt@goodmis.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
mingo@redhat.com, linux-kernel@vger.kernel.org,
seungho1.park@lge.com, jolsa@redhat.com
Subject: Re: [PATCH v5 2/2] tracing: add additional marks to signal very large time
Date: Thu, 20 Nov 2014 08:49:00 -0500 [thread overview]
Message-ID: <20141120084900.10c8a2f5@gandalf.local.home> (raw)
In-Reply-To: <20141120063846.GD27177@byungchulpark-X58A-UD3R>
On Thu, 20 Nov 2014 15:38:46 +0900
Byungchul Park <byungchul.park@lge.com> wrote:
> > I think it's impossible since it's always true that 'd >= 0'.
> >
>
> If someone won't define "MARK(0ULL, ' ')", then i think it can happen. :)
>
Actually, remove the "MARK(0ULL, ' ')" and keep the return value as is.
But clean it up a little like this:
return (i == size) ? ' ' : mark[i].sym;
Notice the space between "size)" and "?"
-- Steve
next prev parent reply other threads:[~2014-11-20 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 0:15 [PATCH v5 0/2] tracing: signaling large duration and delay byungchul.park
2014-11-20 0:15 ` [PATCH v5 1/2] tracing, function_graph: fix micro seconds notation in comment byungchul.park
2014-11-20 0:50 ` Steven Rostedt
2014-11-20 0:15 ` [PATCH v5 2/2] tracing: add additional marks to signal very large time byungchul.park
2014-11-20 1:06 ` Steven Rostedt
2014-11-20 6:05 ` Namhyung Kim
2014-11-20 6:38 ` Byungchul Park
2014-11-20 13:49 ` Steven Rostedt [this message]
2014-11-20 13:46 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120084900.10c8a2f5@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=byungchul.park@lge.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=seungho1.park@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®