From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752835AbaKUURj (ORCPT ); Fri, 21 Nov 2014 15:17:39 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:38507 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbaKUURi (ORCPT ); Fri, 21 Nov 2014 15:17:38 -0500 Date: Fri, 21 Nov 2014 15:17:35 -0500 (EST) Message-Id: <20141121.151735.1432199551923486515.davem@davemloft.net> To: arnd@arndb.de Cc: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com, rpao@paonet.org, linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org Subject: Re: [PATCH 1/2] net/am2150: fix nmclan_cs.c shared interrupt handling From: David Miller In-Reply-To: <4353896.15JnC91eLO@wuerfel> References: <4353896.15JnC91eLO@wuerfel> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Fri, 21 Nov 2014 12:17:37 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Thu, 20 Nov 2014 16:11:14 +0100 > A recent patch tried to work around a valid warning for the use of a > deprecated interface by blindly changing from the old > pcmcia_request_exclusive_irq() interface to pcmcia_request_irq(). > > This driver has an interrupt handler that is not currently aware > of shared interrupts, but can be easily converted to be. > At the moment, the driver reads the interrupt status register > repeatedly until it contains only zeroes in the interesting bits, > and handles each bit individually. > > This patch adds the missing part of returning IRQ_NONE in case none > of the bits are set to start with, so we can move on to the next > interrupt source. > > Signed-off-by: Arnd Bergmann > Fixes: 5f5316fcd08ef7 ("am2150: Update nmclan_cs.c to use update PCMCIA API") > --- > I had this patch in my queue of things to submit and noticed that > the warning had gone away upstream but my patch was still there. > > For all I can tell, the driver is broken without this, although it > would rarely be a problem. I'm happy for this to go alongside patch #2 via another tree: Acked-by: David S. Miller