mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Anjana Sasindran <anjanasasindran123@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	devel@driverdev.osuosl.org
Subject: Re: [PATCH] drivers:staging:skein:skein_generic.c: Fixed a whitespace error
Date: Sat, 22 Nov 2014 14:01:06 +0530	[thread overview]
Message-ID: <20141122083106.GB6591@sudip-PC> (raw)
In-Reply-To: <1416642119-5827-1-git-send-email-anjanasasindran123@gmail.com>

On Sat, Nov 22, 2014 at 01:11:59PM +0530, Anjana Sasindran wrote:
>      This patch fixes the checkpatch.pl error:
> 
it still does not apply to next-20141121
>      ERROR: trailing whitespace

and i am not seeing any trailing whitespace at line 191 of this file.
if you base your patch on next-20141121 your patch should have been:

diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
index 60d16b6..8660509 100644
--- a/drivers/staging/skein/skein_generic.c
+++ b/drivers/staging/skein/skein_generic.c
@@ -191,7 +191,6 @@ static int __init skein_generic_init(void)

	 return 0;

-               
 unreg512:
	 crypto_unregister_shash(&alg512);
 unreg256:


thanks
sudip

> 
> Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
> ---
>  drivers/staging/skein/skein_generic.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c
> index 7096d5a..268e4de 100644
> --- a/drivers/staging/skein/skein_generic.c
> +++ b/drivers/staging/skein/skein_generic.c
> @@ -188,7 +188,6 @@ static int __init skein_generic_init(void)
>  		goto unreg256;
>  	if (crypto_register_shash(&alg1024))
>  		goto unreg512;
> -
>  	return 0;
>  unreg512:
>  	crypto_unregister_shash(&alg512);
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2014-11-22  8:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-22  7:41 Anjana Sasindran
2014-11-22  8:31 ` Sudip Mukherjee [this message]
2014-11-22 18:58 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141122083106.GB6591@sudip-PC \
    --to=sudipm.mukherjee@gmail.com \
    --cc=anjanasasindran123@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®