From: Greg KH <gregkh@linuxfoundation.org>
To: Adrian Nicoara <anicoara@uwaterloo.ca>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: lustre: Fix sparse warnings for static declarations
Date: Sat, 22 Nov 2014 11:00:18 -0800 [thread overview]
Message-ID: <20141122190018.GA26638@kroah.com> (raw)
In-Reply-To: <20141111051528.GB24026@uwaterloo.ca>
On Tue, Nov 11, 2014 at 12:15:28AM -0500, Adrian Nicoara wrote:
> All the changes are against variables/functions that are only accessed from
> within the same file. If the scope needs to change later on, the static keyword
> can be removed.
>
> Build tested.
>
> Signed-off-by: Adrian Nicoara <anicoara@uwaterloo.ca>
Adds a few build warnings, so I can't take this patch, sorry :(
ALWAYS test your patches.
prev parent reply other threads:[~2014-11-22 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 5:15 Adrian Nicoara
2014-11-22 19:00 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141122190018.GA26638@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=anicoara@uwaterloo.ca \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®