From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
rusty@au1.ibm.com, nab@linux-iscsi.org, pbonzini@redhat.com
Subject: Re: [PATCH v3 00/41] linux: towards virtio-1 guest support
Date: Tue, 25 Nov 2014 10:05:40 +0100 [thread overview]
Message-ID: <20141125100540.3b747d12.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20141124191205.GA8049@redhat.com>
On Mon, 24 Nov 2014 21:12:05 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Mon, Nov 24, 2014 at 07:48:31PM +0100, Cornelia Huck wrote:
> > vring_transport_features() seems to knock off the version 1 bit (I
> > wonder why I did not see that before, maybe VIRTIO_TRANSPORT_F_END had
> > not been increased before?). If I add VIRTIO_F_VERSION_1 in this
> > function, virtio-net and virtio-blk seem to work fine with version 1 on
> > virtio-ccw (tested with my old virtio-1 qemu branch).
>
> What if we just move VIRTIO_TRANSPORT_F_END back for now?
> Does patch below fix it for you?
It does.
>
> > I'll try to do a bit of reviewing tomorrow.
>
> BTW could you post your latest qemu bits please?
I haven't done much work on virtio-1 lately, but I could rebase my
existing branch to current qemu.
next prev parent reply other threads:[~2014-11-25 9:06 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 11:52 Michael S. Tsirkin
2014-11-24 11:52 ` [PATCH v3 01/41] virtio: use u32, not bitmap for struct virtio_device's features Michael S. Tsirkin
2014-11-24 11:52 ` [PATCH v3 02/41] virtio: add support for 64 bit features Michael S. Tsirkin
2014-11-24 11:52 ` [PATCH v3 03/41] virtio: add virtio 1.0 feature bit Michael S. Tsirkin
2014-11-24 11:52 ` [PATCH v3 04/41] virtio: memory access APIs Michael S. Tsirkin
2014-11-24 12:03 ` Geert Uytterhoeven
2014-11-24 12:15 ` Michael S. Tsirkin
2014-11-24 12:58 ` Geert Uytterhoeven
2014-11-24 18:49 ` Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 05/41] virtio_ring: switch to new " Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 06/41] virtio_config: endian conversion for v1.0 Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 07/41] virtio: allow transports to get avail/used addresses Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 08/41] virtio: set FEATURES_OK Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 09/41] virtio: simplify feature bit handling Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 10/41] virtio: add legacy feature table support Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 11/41] virtio_net: v1.0 endianness Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 12/41] virtio_blk: v1.0 support Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 13/41] KVM: s390: Set virtio-ccw transport revision Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 14/41] KVM: s390: virtio-ccw revision 1 SET_VQ Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 15/41] KVM: s390 allow virtio_ccw status writes to fail Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 16/41] KVM: s390: enable virtio-ccw revision 1 Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 17/41] virtio_blk: make serial attribute static Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 18/41] virtio_blk: fix race at module removal Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 19/41] virtio_net: pass vi around Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 20/41] virtio_net: get rid of virtio_net_hdr/skb_vnet_hdr Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 21/41] virtio_net: stricter short buffer length checks Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 22/41] virtio_net: bigger header when VERSION_1 is set Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 23/41] virtio_net: enable v1.0 support Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 24/41] vhost: add memory access wrappers Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 25/41] vhost/net: force len for TX to host endian Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 26/41] vhost: virtio 1.0 endian-ness support Michael S. Tsirkin
2014-11-24 14:28 ` Cedric Le Goater
2014-11-24 20:28 ` Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 27/41] vhost: make features 64 bit Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 28/41] vhost/net: virtio 1.0 byte swap Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 29/41] vhost/net: larger header for virtio 1.0 Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 30/41] vhost/net: enable " Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 31/41] vhost/net: suppress compiler warning Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 32/41] tun: move internal flag defines out of uapi Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 33/41] tun: drop most type defines Michael S. Tsirkin
2014-11-24 11:55 ` [PATCH v3 34/41] tun: add VNET_LE flag Michael S. Tsirkin
2014-11-24 11:55 ` [PATCH v3 35/41] tun: TUN_VNET_LE support, fix sparse warnings for virtio headers Michael S. Tsirkin
2014-11-24 11:55 ` [PATCH v3 36/41] macvtap: TUN_VNET_HDR support Michael S. Tsirkin
2014-11-24 11:55 ` [PATCH v3 37/41] virtio_scsi: v1.0 support Michael S. Tsirkin
2014-11-24 11:55 ` [PATCH v3 38/41] virtio_scsi: move to uapi Michael S. Tsirkin
2014-11-24 11:55 ` [PATCH v3 39/41] virtio_scsi: export to userspace Michael S. Tsirkin
2014-11-24 11:55 ` [PATCH v3 40/41] vhost/scsi: partial virtio 1.0 support Michael S. Tsirkin
2014-11-24 11:55 ` [PATCH v3 41/41] af_packet: virtio 1.0 stubs Michael S. Tsirkin
2014-11-24 12:15 ` [PATCH v3 00/41] linux: towards virtio-1 guest support Paolo Bonzini
2014-11-24 18:35 ` David Miller
2014-11-24 18:48 ` Cornelia Huck
2014-11-24 19:12 ` Michael S. Tsirkin
2014-11-25 9:05 ` Cornelia Huck [this message]
2014-11-24 21:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125100540.3b747d12.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=pbonzini@redhat.com \
--cc=rusty@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome