From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephan Mueller <smueller@chronox.de>
Cc: Daniel Borkmann <dborkman@redhat.com>,
"'Quentin Gouchet'" <quentin.gouchet@gmail.com>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH v3 4/7] crypto: AF_ALG: add AEAD support
Date: Tue, 25 Nov 2014 22:58:50 +0800 [thread overview]
Message-ID: <20141125145850.GD8541@gondor.apana.org.au> (raw)
In-Reply-To: <5492722.Cc6uZ9OM2L@tauon>
On Mon, Nov 24, 2014 at 03:58:34PM +0100, Stephan Mueller wrote:
> Ok. But in the code you see that skcipher is a 100% subset of AEAD. For
> AEAD, all we need to do in addition to normal symmetric ciphers is to
> select the AEAD kernel crypto API calls, to locate and use the AD and to
> ensure we have the right memory size to process the tag.
There is still one fundamental difference between AEAD and ciphers.
Namely that ciphers can operate as you go while AEAD requests must
be done in one lot. So that should make the AEAD code simpler vs.
ciphers.
I think the best course of action for now is to start with sharing
no code and then chop bits off as we see fit.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2014-11-25 14:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 5:29 [PATCH v3 0/7] crypto: AF_ALG: add AEAD and RNG support Stephan Mueller
2014-11-21 5:30 ` [PATCH v3 1/7] crypto: AF_ALG: add user space interface for AEAD Stephan Mueller
2014-11-24 14:26 ` Herbert Xu
2014-11-21 5:30 ` [PATCH v3 3/7] crypto: AF_ALG: crypto API calls to inline functions Stephan Mueller
2014-11-21 5:31 ` [PATCH v3 2/7] crypto: AF_ALG: extend data structuers for AEAD Stephan Mueller
2014-11-21 5:32 ` [PATCH v3 4/7] crypto: AF_ALG: add AEAD support Stephan Mueller
2014-11-24 14:29 ` Herbert Xu
2014-11-24 14:58 ` Stephan Mueller
2014-11-25 14:58 ` Herbert Xu [this message]
2014-11-25 15:08 ` Stephan Mueller
2014-11-24 20:55 ` Stephan Mueller
2014-11-21 5:32 ` [PATCH v3 5/7] crypto: AF_ALG: add random number generator support Stephan Mueller
2014-11-24 14:31 ` Herbert Xu
2014-11-24 15:08 ` Stephan Mueller
2014-11-21 5:33 ` [PATCH v3 6/7] crypto: AF_ALG: enable RNG interface compilation Stephan Mueller
2014-11-21 5:34 ` [PATCH v3 7/7] crypto: AF_ALG: document the user space interface Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125145850.GD8541@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dborkman@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quentin.gouchet@gmail.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®