From: Jason Cooper <jason@lakedaemon.net>
To: Dmitry Torokhov <dtor@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Arnd Bergmann <arnd@arndb.de>,
Kevin Cernekee <cernekee@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip: bcm7120-l2: fix error handling of irq_of_parse_and_map
Date: Wed, 26 Nov 2014 01:36:07 -0500 [thread overview]
Message-ID: <20141126063607.GY22670@titan.lakedaemon.net> (raw)
In-Reply-To: <20141114221614.GA37395@dtor-ws>
On Fri, Nov 14, 2014 at 02:16:14PM -0800, Dmitry Torokhov wrote:
> Return value of irq_of_parse_and_map() is unsigned int, with 0
> indicating failure, so testing for negative result never works.
>
> Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
> ---
>
> Not tested, found by casual code inspection.
>
> drivers/irqchip/irq-bcm7120-l2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Both applied to irqchip/urgent with Florian's Ack and Kevin's Tested-by.
thx,
Jason.
prev parent reply other threads:[~2014-11-26 6:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 22:16 Dmitry Torokhov
2014-11-15 19:41 ` Florian Fainelli
2014-11-15 19:42 ` Kevin Cernekee
2014-11-26 6:36 ` Jason Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126063607.GY22670@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=arnd@arndb.de \
--cc=cernekee@gmail.com \
--cc=dtor@chromium.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®