From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753271AbaKZQiQ (ORCPT ); Wed, 26 Nov 2014 11:38:16 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:39508 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704AbaKZQiO (ORCPT ); Wed, 26 Nov 2014 11:38:14 -0500 Date: Wed, 26 Nov 2014 16:36:01 +0000 From: Mark Brown To: Lars-Peter Clausen Cc: Zidan Wang , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de, ckeepax@opensource.wolfsonmicro.com, Li.Xiubo@freescale.com, patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20141126163601.GH7712@sirena.org.uk> References: <1416999740-21805-1-git-send-email-b50113@freescale.com> <5475BA76.8080809@metafoo.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="iMgEUbSC7F9Xm20w" Content-Disposition: inline In-Reply-To: <5475BA76.8080809@metafoo.de> X-Cookie: Celebrity voices impersonated. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [alsa-devel][PATCH] ASoC: wm8960: LRCM operation should after software reset X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --iMgEUbSC7F9Xm20w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 26, 2014 at 12:33:10PM +0100, Lars-Peter Clausen wrote: > On 11/26/2014 12:02 PM, Zidan Wang wrote: > >When shared_lrclk is set, LRCM will be enabled. But the following software > >reset in wm8960_probe will reset it to the default state. So LRCM operation > >should after software reset. > It's probably a better idea to move the reset (together with the other > register updates) to the I2C driver probe. Yes, this is not a good fix. --iMgEUbSC7F9Xm20w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUdgFwAAoJECTWi3JdVIfQlIoH/A7i3L4kRDUMymQ7qDR9Bsib dDTpun+T1aT5YCnJ1LcpeEPv8f6lihDRN08AB9Arz9asnnnQd9Y8DwulMbPNtbOU fz0w7rWitorqLBLzhBju388DFYxfUiAfO7hySVBzUbbOF54MfzjHOrpV3ylgG7Td Y0WTjAkTMoBa2tMjUgy6gVTC5q+6RNuYzO7m+LFCfkZZ0i/jitk9/ljD7IZoR/QZ e/iOA4mt/Ygh3Oh0w9dAac9P0ACnvBuplh60DxLVGUBTfqjewG8rf1RrBmO3aY3B v/vLIzMDV3QOp35KFOv1An/x83Rkr6koGW0NtfkVVIa/eIVloOc4pnZ6viB6jEs= =pGhp -----END PGP SIGNATURE----- --iMgEUbSC7F9Xm20w--