From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751554AbaK0Pe7 (ORCPT ); Thu, 27 Nov 2014 10:34:59 -0500 Received: from service87.mimecast.com ([91.220.42.44]:45796 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132AbaK0Pe4 convert rfc822-to-8bit (ORCPT ); Thu, 27 Nov 2014 10:34:56 -0500 Date: Thu, 27 Nov 2014 15:34:54 +0000 From: Liviu Dudau To: Marc Zyngier Cc: Arnd Bergmann , Olof Johansson , Mark Rutland , Rob Herring , Ian Campbell , Will Deacon , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] arm64: ARM: Fix the Generic Timers interrupt active level description Message-ID: <20141127153453.GR828@e106497-lin.cambridge.arm.com> References: <1417099005-18638-1-git-send-email-Liviu.Dudau@arm.com> <5477389A.8010606@arm.com> MIME-Version: 1.0 In-Reply-To: <5477389A.8010606@arm.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-OriginalArrivalTime: 27 Nov 2014 15:34:55.0312 (UTC) FILETIME=[B1AD9500:01D00A57] X-MC-Unique: 114112715345407401 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 27, 2014 at 02:43:38PM +0000, Marc Zyngier wrote: > On 27/11/14 14:36, Liviu Dudau wrote: > > The Cortex-A5x TRM states in paragraph "9.2 Generic Timer functional > > description" that generic timers provide an active-LOW interrupt > > output. Fix the device trees to correctly describe this. > > > > While doing this update the CPU mask to match the number of described > > CPUs as well. > > > > Signed-off-by: Liviu Dudau > > --- > > > > Arnd, Olof: This is on top of linux-next/master as it patches the Juno > > as well as all the other ARM DTs. > > > > arch/arm64/boot/dts/arm/foundation-v8.dts | 8 ++++---- > > arch/arm64/boot/dts/arm/juno.dts | 8 ++++---- > > arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 8 ++++---- > > 3 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/arm/foundation-v8.dts b/arch/arm64/boot/dts/arm/foundation-v8.dts > > index 4a06090..27f3296 100644 > > --- a/arch/arm64/boot/dts/arm/foundation-v8.dts > > +++ b/arch/arm64/boot/dts/arm/foundation-v8.dts > > @@ -78,10 +78,10 @@ > > > > timer { > > compatible = "arm,armv8-timer"; > > - interrupts = <1 13 0xff01>, > > - <1 14 0xff01>, > > - <1 11 0xff01>, > > - <1 10 0xff01>; > > + interrupts = <1 13 0xf08>, > > + <1 14 0xf08>, > > + <1 11 0xf08>, > > + <1 10 0xf08>; > > clock-frequency = <100000000>; > > }; > > > > diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts > > index 097ecc4..cb3073e 100644 > > --- a/arch/arm64/boot/dts/arm/juno.dts > > +++ b/arch/arm64/boot/dts/arm/juno.dts > > @@ -98,10 +98,10 @@ > > > > timer { > > compatible = "arm,armv8-timer"; > > - interrupts = , > > - , > > - , > > - ; > > + interrupts = , > > + , > > + , > > + ; > > }; > > > > pmu { > > diff --git a/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts b/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts > > index 572005e..efc59b3 100644 > > --- a/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts > > +++ b/arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts > > @@ -81,10 +81,10 @@ > > > > timer { > > compatible = "arm,armv8-timer"; > > - interrupts = <1 13 0xff01>, > > - <1 14 0xff01>, > > - <1 11 0xff01>, > > - <1 10 0xff01>; > > + interrupts = <1 13 0xf08>, > > + <1 14 0xf08>, > > + <1 11 0xf08>, > > + <1 10 0xf08>; > > clock-frequency = <100000000>; > > }; > > > > > > Sorry, but that's wrong. Despite the *cores* having an level-low output, > the GIC only triggers on *level-high*. Yes, there is probably an > inverter in between. BTW, should I also update the bindings example to get this right? Regards, Liviu > > M. > -- > Jazz is not dead. It just smells funny... > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯