From: Sascha Hauer <s.hauer@pengutronix.de>
To: Flora Fu <flora.fu@mediatek.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Grant Likely <grant.likely@linaro.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Sandeep Nair <sandeep_n@ti.com>,
Andy Gross <agross@codeaurora.org>,
Linus Walleij <linus.walleij@linaro.org>,
Stephen Warren <swarren@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Vladimir Murzin <vladimir.murzin@arm.com>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
"Joe.C" <yingjoe.chen@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
srv_heupstream@mediatek.com, Sascha Hauer <kernel@pengutronix.de>,
Eddie Huang <eddie.huang@mediatek.com>,
Dongdong Cheng <dongdong.cheng@mediatek.com>
Subject: Re: [PATCH v2 8/8] ARM: dts: mt8135: Add support for MT6397 regulator
Date: Mon, 1 Dec 2014 07:40:11 +0100 [thread overview]
Message-ID: <20141201064011.GC30369@pengutronix.de> (raw)
In-Reply-To: <1417403967.9547.2.camel@mtksdaap41>
On Mon, Dec 01, 2014 at 11:19:25AM +0800, Flora Fu wrote:
> Hi, Mark,
>
> On Fri, 2014-11-28 at 15:30 +0000, Mark Brown wrote:
> > On Fri, Nov 28, 2014 at 11:54:34AM +0800, Flora Fu wrote:
> >
> > > Add device tree for MT6397 regulators in mt8135.dtsi.
> > >
> > > Signed-off-by: Flora Fu <flora.fu@mediatek.com>
> > > ---
> > > arch/arm/boot/dts/mt8135.dtsi | 192 ++++++++++++++++++++++++++++++++++++++++++
> >
> > This appears to be the DT fragment for a SoC but you are defining the
> > system integration for the PMIC. That's bad, the PMIC is a separate
> > device so should be hooked up by the board using it. If there's common
> > elements from a reference design they should be in their own .dtsi.
> >
>
> Do you mean that we should add a mt6397.dtsi and include it from
> mt8135.dtsi? For board specific, update them in mt8135.dtsi?
You can't include it from mt8135.dtsi since here you don't know if a
mt6397.dtsi is connected. You have to include both the mt8135.dtsi and
the mt6397.dtsi from the board file.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2014-12-01 6:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1417146874-5232-1-git-send-email-flora.fu@mediatek.com>
[not found] ` <1417146874-5232-4-git-send-email-flora.fu@mediatek.com>
2014-11-28 15:22 ` [PATCH v2 3/8] regulator: MT6397: " Mark Brown
[not found] ` <1417402305.30873.78.camel@mtksdaap41>
2014-12-01 16:12 ` Mark Brown
[not found] ` <1417146874-5232-9-git-send-email-flora.fu@mediatek.com>
2014-11-28 15:30 ` [PATCH v2 8/8] ARM: dts: mt8135: " Mark Brown
[not found] ` <1417403967.9547.2.camel@mtksdaap41>
2014-12-01 6:40 ` Sascha Hauer [this message]
2014-12-01 11:16 ` Mark Brown
[not found] ` <1417146874-5232-7-git-send-email-flora.fu@mediatek.com>
2014-11-28 15:30 ` [PATCH v2 6/8] dt-bindings: Add document " Mark Brown
[not found] ` <1417146874-5232-2-git-send-email-flora.fu@mediatek.com>
2014-11-28 15:32 ` [PATCH v2 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC Mark Brown
2014-12-01 7:04 ` [PATCH v2 0/8] Add Support for MediaTek PMIC MT6397 MFD Core and Regulator Sascha Hauer
[not found] ` <1417146874-5232-3-git-send-email-flora.fu@mediatek.com>
2014-12-01 11:47 ` [PATCH v2 2/8] mfd: MT6397: Add support for PMIC MT6397 MFD Lee Jones
2014-12-03 8:40 ` Flora Fu
2014-12-03 9:26 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201064011.GC30369@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=agross@codeaurora.org \
--cc=ashwin.chaugule@linaro.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dongdong.cheng@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=flora.fu@mediatek.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=pdeschrijver@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=sandeep_n@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=srv_heupstream@mediatek.com \
--cc=swarren@nvidia.com \
--cc=treding@nvidia.com \
--cc=vladimir.murzin@arm.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome