From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753199AbaLALRf (ORCPT ); Mon, 1 Dec 2014 06:17:35 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:44951 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752945AbaLALRd (ORCPT ); Mon, 1 Dec 2014 06:17:33 -0500 Date: Mon, 1 Dec 2014 11:16:12 +0000 From: Mark Brown To: Flora Fu Cc: Rob Herring , Matthias Brugger , Samuel Ortiz , Lee Jones , Liam Girdwood , linux-arm-kernel@lists.infradead.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Grant Likely , Santosh Shilimkar , Sandeep Nair , Andy Gross , Linus Walleij , Stephen Warren , Thierry Reding , Peter De Schrijver , Catalin Marinas , Vladimir Murzin , Ashwin Chaugule , "Joe.C" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com, Sascha Hauer , Eddie Huang , Dongdong Cheng Message-ID: <20141201111612.GF7712@sirena.org.uk> References: <1417146874-5232-1-git-send-email-flora.fu@mediatek.com> <1417146874-5232-9-git-send-email-flora.fu@mediatek.com> <20141128153008.GS7712@sirena.org.uk> <1417403967.9547.2.camel@mtksdaap41> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fUAgMX1mmt35sX2N" Content-Disposition: inline In-Reply-To: <1417403967.9547.2.camel@mtksdaap41> X-Cookie: Celebrity voices impersonated. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 8/8] ARM: dts: mt8135: Add support for MT6397 regulator X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fUAgMX1mmt35sX2N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 01, 2014 at 11:19:25AM +0800, Flora Fu wrote: > On Fri, 2014-11-28 at 15:30 +0000, Mark Brown wrote:=20 > > This appears to be the DT fragment for a SoC but you are defining the > > system integration for the PMIC. That's bad, the PMIC is a separate > > device so should be hooked up by the board using it. If there's common > > elements from a reference design they should be in their own .dtsi. > Do you mean that we should add a mt6397.dtsi and include it from > mt8135.dtsi? For board specific, update them in mt8135.dtsi?=20 More likely you should just add any integration needed in the board file. There should be no need to specify anything generically for the regulators on a PMIC except registering the device. --fUAgMX1mmt35sX2N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUfE37AAoJECTWi3JdVIfQi20H/im8teQUzpvlbmmrjqEIK63a HqY0GfzbjgID2Qfnt6hRrKwg7wmB9jy2iF0I0VuXhlNECm8lFLtlQTkhYr4AOmlO AgAbWIW0zezngY3XmiwCACgJnExUdLaSEPYFuOg6QsM51hMet+6c15mFA2m7SVhL 1rWxLT0L5r9YaWhWPzbQlTBbr45CRHY2s2wuOFmSXTsALymqYM2rFSMmDaWlrXMA VdLit4jpcXbTmilAroblI/wrRsxvxbAN8/7g845mBeQZ9KsErbp3mZ21Zj37vIXj r4DrTMfkNfLhk6qexHR8OCcqPT0Xl1MNX/cW16D36U/qVe5UkNerHsv7z3SBjF8= =YkfB -----END PGP SIGNATURE----- --fUAgMX1mmt35sX2N--