From: Mark Rutland <mark.rutland@arm.com>
To: Stefan Agner <stefan@agner.ch>
Cc: "shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"arnd@arndb.de" <arnd@arndb.de>,
"sre@kernel.org" <sre@kernel.org>, "fkan@apm.com" <fkan@apm.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"dbaryshkov@gmail.com" <dbaryshkov@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] power: reset: read priority from device tree
Date: Mon, 1 Dec 2014 17:11:26 +0000 [thread overview]
Message-ID: <20141201171126.GB22708@leverpostej> (raw)
In-Reply-To: <1417453389-1588-2-git-send-email-stefan@agner.ch>
On Mon, Dec 01, 2014 at 05:03:07PM +0000, Stefan Agner wrote:
> This patch adds an optional property which allows to specify the
> reset source priority. This priority is used by the kernel restart
> handler call chain to sort out the proper reset/restart method.
> Depending on the power design of a board or other machine/board
> specific peculiarity, it is not possible to pick a generic priority.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Documentation/devicetree/bindings/power/reset/syscon-reboot.txt | 3 +++
> drivers/power/reset/syscon-reboot.c | 5 ++++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.txt b/Documentation/devicetree/bindings/power/reset/syscon-reboot.txt
> index 1190631..ee41d9c 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.txt
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.txt
> @@ -11,6 +11,9 @@ Required properties:
> - offset: offset in the register map for the reboot register (in bytes)
> - mask: the reset value written to the reboot register (32 bit access)
>
> +Optional properties:
> +- priority: define the priority of the reset (0-255, defaults to 128)
> +
NAK. This is a leak of Linux-internal details.
What is this necessary for?
Mark.
> Default will be little endian mode, 32 bit access only.
>
> Examples:
> diff --git a/drivers/power/reset/syscon-reboot.c b/drivers/power/reset/syscon-reboot.c
> index 815b901..3060d6b 100644
> --- a/drivers/power/reset/syscon-reboot.c
> +++ b/drivers/power/reset/syscon-reboot.c
> @@ -67,8 +67,11 @@ static int syscon_reboot_probe(struct platform_device *pdev)
> if (of_property_read_u32(pdev->dev.of_node, "mask", &ctx->mask))
> return -EINVAL;
>
> - ctx->restart_handler.notifier_call = syscon_restart_handle;
> ctx->restart_handler.priority = 128;
> + of_property_read_u32(pdev->dev.of_node, "priority",
> + &ctx->restart_handler.priority);
> +
> + ctx->restart_handler.notifier_call = syscon_restart_handle;
> err = register_restart_handler(&ctx->restart_handler);
> if (err)
> dev_err(dev, "can't register restart notifier (err=%d)\n", err);
> --
> 2.1.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-12-01 17:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 17:03 [PATCH v2 0/3] power: reset: vf610 system reset controller Stefan Agner
2014-12-01 17:03 ` [PATCH v2 1/3] power: reset: read priority from device tree Stefan Agner
2014-12-01 17:11 ` Mark Rutland [this message]
2014-12-01 17:22 ` Guenter Roeck
2014-12-01 17:24 ` Stefan Agner
2014-12-01 17:41 ` Mark Rutland
2014-12-01 17:51 ` Guenter Roeck
2014-12-01 17:59 ` Mark Rutland
2014-12-01 18:12 ` Guenter Roeck
2014-12-01 18:18 ` Mark Rutland
2014-12-01 18:50 ` Arnd Bergmann
2014-12-01 17:15 ` Feng Kan
2014-12-01 17:29 ` Stefan Agner
2014-12-01 17:38 ` Feng Kan
2014-12-01 17:42 ` Guenter Roeck
2014-12-01 22:18 ` Stefan Agner
2014-12-01 22:35 ` Guenter Roeck
2014-12-01 17:03 ` [PATCH v2 2/3] ARM: dts: vf610: add system reset controller and syscon-reboot Stefan Agner
2014-12-01 17:03 ` [PATCH v2 3/3] ARM: imx_v6_v7_defconfig: add POWER_RESET_SYSCON Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201171126.GB22708@leverpostej \
--to=mark.rutland@arm.com \
--cc=arnd@arndb.de \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=fkan@apm.com \
--cc=grant.likely@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=sre@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®