From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754626AbaLBN1j (ORCPT ); Tue, 2 Dec 2014 08:27:39 -0500 Received: from hofr.at ([212.69.189.236]:56986 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753363AbaLBN1i (ORCPT ); Tue, 2 Dec 2014 08:27:38 -0500 Date: Tue, 2 Dec 2014 14:27:36 +0100 From: Nicholas Mc Guire To: Michal Marek Cc: Randy Dunlap , Christoph Hellwig , Joe Perches , LKML Subject: Re: [PATCH 4/5] limit _shipped to c h and S files Message-ID: <20141202132736.GB9328@opentech.at> References: <20141202091621.GE13909@opentech.at> <547D924A.2010205@suse.cz> <20141202103231.GA30141@opentech.at> <547DA742.1010806@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <547DA742.1010806@suse.cz> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 02 Dec 2014, Michal Marek wrote: > On 2014-12-02 11:32, Nicholas Mc Guire wrote: > > On Tue, 02 Dec 2014, Michal Marek wrote: > > > >> Dne 2.12.2014 v 10:16 Nicholas Mc Guire napsal(a): > >>> > >>> limit _shipped to c h and S files > >>> > >>> _shipped targets are intended for generated source files which should > >>> not permit .o binary blobs which is currently the case. This patch > >>> simply restricts _shipped targets to .c, .h and .S files. > >> > >> > >> IMO this just adds lines of code without any obvious advantage. The > >> other patches in the series are fine. > >> > > > > The idea simply was to make the behavior of kbuild match the > > documented intent of _shipped files. > > The usage of *.o_shipped is documented by Documentation/kbuild/modules.txt. > I know - and Im looking at how to address this so that it would be out-of-tree only - a minor update of the wording for 3.3 Binary Blobs was sent out as patch - 3.2 change proposal is not yet done. Currently there is no .o_shipped in mainline (linux-next 3.18-rc6, linux-stable 3.18-rc5) so the intent is to rewrite some of those parts to kick the .o_shipped there too. But if there is a legitimate need for .o_shipped then of course this patch (and the changes I'm working on) make no sense at all. My understanding is though that it should not be needed any more. thx! hofrat