On Wed, Dec 03, 2014 at 04:39:01PM +0000, Andrew Jackson wrote: > + /* Iterate over set of channels - independently controlled. > + */ > + do { > + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { > + i2s_write_reg(dev->i2s_base, TCR(ch_reg), > + xfer_resolution); > + i2s_write_reg(dev->i2s_base, TFCR(ch_reg), 0x02); > + irq = i2s_read_reg(dev->i2s_base, IMR(ch_reg)); > + i2s_write_reg(dev->i2s_base, IMR(ch_reg), irq & ~0x30); > + i2s_write_reg(dev->i2s_base, TER(ch_reg), 1); > + } else { > + i2s_write_reg(dev->i2s_base, RCR(ch_reg), > + xfer_resolution); > + i2s_write_reg(dev->i2s_base, RFCR(ch_reg), 0x07); > + irq = i2s_read_reg(dev->i2s_base, IMR(ch_reg)); > + i2s_write_reg(dev->i2s_base, IMR(ch_reg), irq & ~0x03); > + i2s_write_reg(dev->i2s_base, RER(ch_reg), 1); > + } > + } while (ch_reg-- > 0); The normal way to write an iteration would be with a for loop - why are we not doing that? Also I see that you've not sent these as a single thread - please use --thread.