From: Mark Brown <broonie@kernel.org>
To: Zidan Wang <b50113@freescale.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de,
lars@metafoo.de, ckeepax@opensource.wolfsonmicro.com,
Li.Xiubo@freescale.com, patches@opensource.wolfsonmicro.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel][PATCH v2] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK
Date: Thu, 4 Dec 2014 11:25:12 +0000 [thread overview]
Message-ID: <20141204112512.GS7712@sirena.org.uk> (raw)
In-Reply-To: <1417681425-4360-1-git-send-email-b50113@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Thu, Dec 04, 2014 at 04:23:45PM +0800, Zidan Wang wrote:
> If we use PLL to generate sysclk, wm8960_set_dai_pll() will enable PLL. But
> PLL doesn't power down after using codec. So power down PLL in suspend().
That would be a bug in the machine driver, the machine driver should be
disabling the PLL when it suspends since the startup and shutdown of the
PLL need to be coordinated with the input clocks. Besides, if we were
doing this in the CODEC driver then as I said last time the PLL needs to
be restored on resume since the machine driver should be able to expect
that settings it has made are preserved (eg, if it sets things up on
init).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-12-04 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 8:23 Zidan Wang
2014-12-04 11:25 ` Mark Brown [this message]
2014-12-04 12:34 ` Zidan Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204112512.GS7712@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=b50113@freescale.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®