From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933196AbaLDVrT (ORCPT ); Thu, 4 Dec 2014 16:47:19 -0500 Received: from 251.110.2.81.in-addr.arpa ([81.2.110.251]:58660 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753381AbaLDVrR (ORCPT ); Thu, 4 Dec 2014 16:47:17 -0500 Date: Thu, 4 Dec 2014 21:45:46 +0000 From: One Thousand Gnomes To: "Paul E. McKenney" Cc: Linus Torvalds , "linux-arch@vger.kernel.org" , Davidlohr Bueso , Dmitry Vyukov , Peter Zijlstra , Linux Kernel Mailing List , Ingo Molnar Subject: Re: [PATCH RFC] locking: Add volatile to arch_spinlock_t structures Message-ID: <20141204214546.76b7b7cd@lxorguk.ukuu.org.uk> In-Reply-To: <20141204183628.GT25340@linux.vnet.ibm.com> References: <20141204062005.GA2553@linux.vnet.ibm.com> <20141204070248.GJ25340@linux.vnet.ibm.com> <20141204183628.GT25340@linux.vnet.ibm.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.24; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > anywhere in that translation unit. After all, any non-static function > in that translation unit might be called from some other translation > unit that -did- use locking or whatever. > > I will let you know how it goes. ;-) It breaks DEC10 ;-) If there is kickback over things like optimisation perhaps the gcc maintainers could at least consider something like int __attribute((threadsafe)) fred; ?? Alan