From: Jeremiah Mahler <jmmahler@gmail.com>
To: "Joshua I. James" <joshua@cybercrimetech.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: kernel: fixed style warnings in acct.c
Date: Fri, 5 Dec 2014 03:04:12 -0800 [thread overview]
Message-ID: <20141205110412.GA7840@hudson.localdomain> (raw)
In-Reply-To: <1417754854-6576-1-git-send-email-Joshua@cybercrimetech.com>
Joshua,
On Fri, Dec 05, 2014 at 01:47:34PM +0900, Joshua I. James wrote:
> From: "Joshua I. James" <joshua@cybercrimetech.com>
>
> Fixed style errors identified by checkpatch.
>
> Output of checkpatch:
> WARNING: Missing a blank line after declarations
> WARNING: line over 80 characters
> ERROR: spaces required around that '==' (ctx:VxV)
> +#if ACCT_VERSION==2
>
It looks like your patch is making three types of changes. A single
patch should make a single type of change. For example, you might fix
all the "blank line after declaration" warnings in one patch.
Doing this helps make your patches easier to review, and if a problem
arises later, easier to bisect.
> Signed-off-by: Joshua I. James <joshua@cybercrimetech.com>
> ---
> kernel/acct.c | 22 ++++++++++++++++------
> 1 file changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/acct.c b/kernel/acct.c
> index 33738ef..322159c 100644
> --- a/kernel/acct.c
[...]
It also looks like you only sent this to the linux-kernel mailing list.
You should use scripts/get_maintainer.pl to find who to send it to.
Hope that helps :-)
--
- Jeremiah Mahler
next prev parent reply other threads:[~2014-12-05 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 4:47 Joshua I. James
2014-12-05 11:04 ` Jeremiah Mahler [this message]
2014-12-05 12:00 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141205110412.GA7840@hudson.localdomain \
--to=jmmahler@gmail.com \
--cc=joshua@cybercrimetech.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®