mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremiah Mahler <jmmahler@gmail.com>
To: Athira Lekshmi <andnlnbn18@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: Fixed missing blank line warning
Date: Fri, 5 Dec 2014 06:00:11 -0800	[thread overview]
Message-ID: <20141205140011.GA5184@hudson.localdomain> (raw)
In-Reply-To: <1417787034-7833-1-git-send-email-andnlnbn18@gmail.com>

Athira,

On Fri, Dec 05, 2014 at 07:13:54PM +0530, Athira Lekshmi wrote:
> Fixed the checkpatch warning:
> Missing a blank line after declarations
> 
> Signed-off-by: Athira Lekshmi <andnlnbn18@gmail.com>
> ---
>  drivers/watchdog/mixcomwd.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/mixcomwd.c b/drivers/watchdog/mixcomwd.c
> index be86ea3..03b7612e 100644
> --- a/drivers/watchdog/mixcomwd.c
> +++ b/drivers/watchdog/mixcomwd.c
> @@ -183,6 +183,7 @@ static ssize_t mixcomwd_write(struct file *file, const char __user *data,
>  
>  			for (i = 0; i != len; i++) {
>  				char c;
> +
>  				if (get_user(c, data + i))
>  					return -EFAULT;
>  				if (c == 'V')
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

It is helpful to add a version number when patches are re-submitted to
avoid them being confused for a new patch.  git-format-patch has the
--reroll-count option which makes this easy to do.

-- 
- Jeremiah Mahler

  reply	other threads:[~2014-12-05 14:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05 13:43 Athira Lekshmi
2014-12-05 14:00 ` Jeremiah Mahler [this message]
2014-12-05 14:09   ` Athira Lekshmi C V
2014-12-05 14:40     ` Jeremiah Mahler
2014-12-08  9:42       ` Jeremiah Mahler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141205140011.GA5184@hudson.localdomain \
    --to=jmmahler@gmail.com \
    --cc=andnlnbn18@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®