From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753317AbaLGN7s (ORCPT ); Sun, 7 Dec 2014 08:59:48 -0500 Received: from mail-qa0-f44.google.com ([209.85.216.44]:57082 "EHLO mail-qa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbaLGN7o (ORCPT ); Sun, 7 Dec 2014 08:59:44 -0500 Date: Sun, 7 Dec 2014 08:59:40 -0500 From: Tejun Heo To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , "\\\"Rafael J. Wysocki\\\"" , David Rientjes , Johannes Weiner , Oleg Nesterov , Cong Wang , LKML , linux-pm@vger.kernel.org Subject: Re: [PATCH -v2 2/5] OOM: thaw the OOM victim if it is frozen Message-ID: <20141207135940.GB19034@htj.dyndns.org> References: <20141110163055.GC18373@dhcp22.suse.cz> <1417797707-31699-1-git-send-email-mhocko@suse.cz> <1417797707-31699-3-git-send-email-mhocko@suse.cz> <20141206130657.GC18711@htj.dyndns.org> <20141207102430.GF15892@dhcp22.suse.cz> <20141207104539.GK15892@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141207104539.GK15892@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 07, 2014 at 11:45:39AM +0100, Michal Hocko wrote: .... > void mark_tsk_oom_victim(struct task_struct *tsk) > { > set_tsk_thread_flag(tsk, TIF_MEMDIE); > + __thaw_task(tsk); Yeah, this is a lot better. Maybe we can add a comment at least pointing readers to where to look at to understand what's going on? This stems from the fact that OOM killer which essentially is a memory reclaim operation overrides freezing. It'd be nice if that is documented somehow. Thanks. -- tejun