From: David Miller <davem@davemloft.net>
To: guz.fnst@cn.fujitsu.com
Cc: joe@perches.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] net: introduce helper macra CMSG_FOREACH_HDR
Date: Tue, 09 Dec 2014 15:23:25 -0500 (EST) [thread overview]
Message-ID: <20141209.152325.555830295797189797.davem@davemloft.net> (raw)
In-Reply-To: <54816CD3.90107@cn.fujitsu.com>
From: Gu Zheng <guz.fnst@cn.fujitsu.com>
Date: Fri, 5 Dec 2014 16:29:07 +0800
> Hi Joe,
> Thanks for your comment.
> On 12/05/2014 04:02 PM, Joe Perches wrote:
>
>> On Fri, 2014-12-05 at 15:14 +0800, Gu Zheng wrote:
>>> Introduce helper macra
>>
>> macro
>
> Ah~, it's a typo.
>
>>
>>> CMSG_FOREACH_HDR as a wrapper of the enumerating
>>> cmsghdr from msghdr, just cleanup.
>>
>> maybe better to use lower case "for_each_cmsg_hdr"
>> or some such.
>
> But this will make it out of the ordinary, as the existed ones
> are all upper.
>
> David, what's your opinion?
I think lowercase looks much better.
prev parent reply other threads:[~2014-12-09 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 7:14 Gu Zheng
2014-12-05 8:02 ` Joe Perches
2014-12-05 8:29 ` Gu Zheng
2014-12-09 20:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209.152325.555830295797189797.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=guz.fnst@cn.fujitsu.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®