From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933073AbaLJUWG (ORCPT ); Wed, 10 Dec 2014 15:22:06 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:47462 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932374AbaLJUWB (ORCPT ); Wed, 10 Dec 2014 15:22:01 -0500 Date: Wed, 10 Dec 2014 15:21:57 -0500 (EST) Message-Id: <20141210.152157.830723410034718607.davem@davemloft.net> To: joe@perches.com Cc: acme@ghostprotocols.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2] llc: Make llc_conn_ev_qfyr_t function pointer arrays const From: David Miller In-Reply-To: <1418233437.18092.7.camel@perches.com> References: <1418228330.18092.3.camel@perches.com> <1418233437.18092.7.camel@perches.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Wed, 10 Dec 2014 12:22:01 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches Date: Wed, 10 Dec 2014 09:43:57 -0800 > It's better when function pointer arrays aren't modifiable. > > Net change from original: > > $ size net/llc/built-in.o.* > text data bss dec hex filename > 61065 12886 1344 75295 1261f net/llc/built-in.o.new > 47113 27030 1344 75487 126df net/llc/built-in.o.old > > Signed-off-by: Joe Perches Applied.