From: Jason Cooper <jason@lakedaemon.net>
To: Beniamino Galvani <b.galvani@gmail.com>
Cc: Yingjoe Chen <yingjoe.chen@mediatek.com>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>,
srv_heupstream@mediatek.com, hc.yen@mediatek.com,
yh.chen@mediatek.com, linux-kernel@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
nathan.chung@mediatek.com, Sascha Hauer <kernel@pengutronix.de>,
eddie.huang@mediatek.com, yingjoe.chen@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] irqchip: mediatek: Use IS_ERR() instead of NULL pointer check
Date: Wed, 10 Dec 2014 07:53:13 -0500 [thread overview]
Message-ID: <20141210125313.GJ22670@titan.lakedaemon.net> (raw)
In-Reply-To: <20141210121442.GA14485@gmail.com>
On Wed, Dec 10, 2014 at 01:14:43PM +0100, Beniamino Galvani wrote:
> On Wed, Dec 10, 2014 at 05:55:02PM +0800, Yingjoe Chen wrote:
> > Beniamino reported a kernel oops caused by an invalid DT file for the
> > mediatek interrupt polarity extension.
> >
> > The reason is that the interrupt polarity support for mediatek chips
> > merely checks for NULL pointer instead of a casted error return
> > value in mtk_sysirq_of_init() so any other casted error value passes
> > the NULL pointer check and causes a kernel panic when dereferenced.
> >
> > Use IS_ERR() and return the error value via PTR_ERR().
> >
> > Reported-and-tested-by: Beniamino Galvani <b.galvani@gmail.com>
>
> Well, actually I only reported the bug and didn't do any test. Can the
> "-and-tested" portion of the tag be dropped while applying the patch?
I'd prefer that it be tested before applying. Would you mind confirming
that the oops is gone with this patch applied?
thx,
Jason.
next prev parent reply other threads:[~2014-12-10 12:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 15:03 [PATCH] irqchip: mediatek: Fix error return code detection Yingjoe Chen
2014-12-08 20:30 ` Thomas Gleixner
2014-12-09 6:11 ` Yingjoe Chen
2014-12-10 9:55 ` [PATCH v2] irqchip: mediatek: Use IS_ERR() instead of NULL pointer check Yingjoe Chen
2014-12-10 12:14 ` Beniamino Galvani
2014-12-10 12:53 ` Jason Cooper [this message]
2014-12-10 13:55 ` Yingjoe Chen
2014-12-10 20:08 ` Beniamino Galvani
2014-12-12 15:15 ` [PATCH v3] irqchip: mtk-sysirq: " Yingjoe Chen
2015-01-07 2:08 ` [PATCH v2] irqchip: mediatek: " Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210125313.GJ22670@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=b.galvani@gmail.com \
--cc=eddie.huang@mediatek.com \
--cc=hc.yen@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=nathan.chung@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
--cc=yh.chen@mediatek.com \
--cc=yingjoe.chen@gmail.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®