From: Mark Brown <broonie@kernel.org>
To: Kevin Strasser <kevin.strasser@intel.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Vinod Koul <vinod.koul@intel.com>,
Mengdong Lin <mengdong.lin@intel.com>,
Yang Fang <yang.a.fang@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: Intel: fix possible acpi enumeration panic
Date: Thu, 11 Dec 2014 13:20:26 +0000 [thread overview]
Message-ID: <20141211132026.GY11764@sirena.org.uk> (raw)
In-Reply-To: <1418282517-851-1-git-send-email-kevin.strasser@intel.com>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On Wed, Dec 10, 2014 at 11:21:57PM -0800, Kevin Strasser wrote:
> A crash can occur on some platforms where adsp is enumerated but codec
> is not matched. Check that the codec_id string is valid before
> attempting to match.
> - for (mach = machines; mach->codec_id; mach++)
> + for (mach = machines; mach->codec_id[0]; mach++)
This changes the check from verifying if a codec_id is present to
verifying if the first character in the codec_id is non-NULL. That
doesn't seem obviously safer and the tables of machines seem to be
terminated by having an entry with all fields set to zero (which is
a common idiom in Linux) which would now crash with this change.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-12-11 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 7:21 Kevin Strasser
2014-12-11 13:20 ` Mark Brown [this message]
2014-12-11 21:55 ` Strasser, Kevin
2014-12-15 17:06 ` Mark Brown
2014-12-15 23:22 ` [alsa-devel] " Kevin Strasser
2014-12-16 0:15 ` [PATCH v2] " Kevin Strasser
2014-12-16 11:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211132026.GY11764@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kevin.strasser@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mengdong.lin@intel.com \
--cc=vinod.koul@intel.com \
--cc=yang.a.fang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®