From: Mark Brown <broonie@kernel.org>
To: Ben Zhang <benzh@chromium.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Bard Liao <bardliao@realtek.com>,
Oder Chiou <oder_chiou@realtek.com>,
Anatol Pomozov <anatol@google.com>,
Dylan Reid <dgreid@chromium.org>,
Albert Chen <albertchen@realtek.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage
Date: Fri, 12 Dec 2014 13:27:32 +0000 [thread overview]
Message-ID: <20141212132732.GK11764@sirena.org.uk> (raw)
In-Reply-To: <1418271327-14710-2-git-send-email-benzh@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
On Wed, Dec 10, 2014 at 08:15:26PM -0800, Ben Zhang wrote:
> The MICBIAS voltage for IN1 can be set to 1.476V/2.970V/1.242V/2.475V
The changelog says "platform config" but this is adding DT binding.
> +- realtek,micbias1
> + Select 0/1/2/3 to set MICBIAS1 voltage to 1.476V/2.970V/1.242V/2.475V
> +
Why is this being specified as some magic number rather than using the
voltage (or at least providing defines for the voltage) - this is going
to do little to make the DT legible and...
> +enum rt5677_micbias {
> + RT5677_MICBIAS_1_476V = 0,
> + RT5677_MICBIAS_2_970V = 1,
> + RT5677_MICBIAS_1_242V = 2,
> + RT5677_MICBIAS_2_475V = 3,
> +};
...I see there are defined for platform data.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-12-12 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 4:15 [PATCH 1/3] ASoC: rt5677: add REGMAP_I2C and REGMAP_IRQ dependency Ben Zhang
2014-12-11 4:15 ` [PATCH 2/3] ASoC: rt5677: add a platform config option for MICBIAS voltage Ben Zhang
2014-12-12 13:27 ` Mark Brown [this message]
2014-12-12 23:48 ` Ben Zhang
2014-12-15 12:20 ` Mark Brown
2014-12-11 4:15 ` [PATCH 3/3] ASoC: rt5677: add a platform config option for DACREF source Ben Zhang
2014-12-12 13:34 ` Mark Brown
2014-12-12 13:25 ` [PATCH 1/3] ASoC: rt5677: add REGMAP_I2C and REGMAP_IRQ dependency Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141212132732.GK11764@sirena.org.uk \
--to=broonie@kernel.org \
--cc=albertchen@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=anatol@google.com \
--cc=bardliao@realtek.com \
--cc=benzh@chromium.org \
--cc=dgreid@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®