mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Vinson Lee <vlee@twopensource.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Michal Hocko <mhocko@suse.cz>,
	Josh Triplett <josh@joshtriplett.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Fabian Frederick <fabf@skynet.be>,
	Bertrand Jacquin <beber@meleeweb.net>,
	Andy Lutomirski <luto@amacapital.net>,
	Pranith Kumar <bobby.prani@gmail.com>,
	Peter Foley <pefoley2@pefoley.com>,
	Clark Williams <clark.williams@gmail.com>,
	Mel Gorman <mgorman@suse.de>,
	linux-kernel@vger.kernel.org, Nate Stahl <stahl@twitter.com>,
	Vinson Lee <vlee@twitter.com>
Subject: Re: [PATCH] Increase maximum size of dmesg buffer to 16MB.
Date: Fri, 12 Dec 2014 23:45:15 +0100	[thread overview]
Message-ID: <20141212224515.GU25677@wotan.suse.de> (raw)
In-Reply-To: <1418423906-5461-1-git-send-email-vlee@twopensource.com>

On Fri, Dec 12, 2014 at 02:38:26PM -0800, Vinson Lee wrote:
> From: Nate Stahl <stahl@twitter.com>
> 
> A full task stack dump of all tasks on a machine can generate more than
> 4MB of output to dmesg. Dumping this data to the serial console causes
> the machine to hang for a number of minutes (an unacceptable impact),
> but dumping the same data to memory is feasible if the dmesg buffer is
> sized large enough to hold the output. Set to 16MB which will hopefully
> be large enough to handle a dump from any of our servers at this time.
> 
> Signed-off-by: Nate Stahl <stahl@twitter.com>
> Signed-off-by: Vinson Lee <vlee@twitter.com>

Isn't this the perpetual issue of having large number of CPUs? If so
consider use of LOG_CPU_MAX_BUF_SHIFT instead, otherwise clarifying how
this would be a different issue would be good. LOG_CPU_MAX_BUF_SHIFT
should scale nicely but you can increase it as well, is it being used?

 Luis

  reply	other threads:[~2014-12-12 22:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-12 22:38 Vinson Lee
2014-12-12 22:45 ` Luis R. Rodriguez [this message]
2014-12-12 23:07   ` Vinson Lee
2014-12-12 23:29     ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141212224515.GU25677@wotan.suse.de \
    --to=mcgrof@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=beber@meleeweb.net \
    --cc=bobby.prani@gmail.com \
    --cc=clark.williams@gmail.com \
    --cc=fabf@skynet.be \
    --cc=geert@linux-m68k.org \
    --cc=hannes@cmpxchg.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pefoley2@pefoley.com \
    --cc=stahl@twitter.com \
    --cc=vlee@twitter.com \
    --cc=vlee@twopensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®