From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: peterhuewe@gmx.de
Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>,
Ashley Lai <ashley@ashleylai.com>,
Marcel Selhorst <tpmdd@selhorst.net>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
josh@joshtriplett.org, christophe.ricard@gmail.com,
jason.gunthorpe@obsidianresearch.com, linux-api@vger.kernel.org,
trousers-tech@lists.sourceforge.net
Subject: Re: [PATCH v10 1/8] tpm: merge duplicate transmit_cmd() functions
Date: Sun, 14 Dec 2014 17:42:33 +0200 [thread overview]
Message-ID: <20141214154233.GA14110@intel.com> (raw)
In-Reply-To: <889c95a4-ae60-44db-be8a-fd56a9497c78@email.android.com>
On Sun, Dec 14, 2014 at 04:31:10PM +0100, peterhuewe@gmx.de wrote:
>
>
> On 14. Dezember 2014 15:57:10 MEZ, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote:
> >On Sun, 2014-12-14 at 09:03 -0500, Stefan Berger wrote:
> >> On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote:
> >> > Merged transmit_cmd() functions in tpm-interface.c and tpm-sysfs.c.
> >> > Added "tpm_" prefix for consistency sake. Changed cmd parameter as
> >> > opaque. This enables to use separate command structures for TPM1
> >> > and TPM2 commands in future. Loose coupling works fine here.
> >> >
> >> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >> > Reviewed-by: Jasob Gunthorpe <jason.gunthorpe@obsidianresearch.com>
> >> > Reviewed-by: Stephan Berger <stephan.berger@linux.vnet.ibm.com>
> >>
> >> Not quite ... Stefan Berger <stefanb@linux.vnet.ibm.com>
> >
> >Oops. Peter, I guess you could fix those or? My apologies.
> >
> >> Stefan
> >
> >/Jarkko
> I'll fix this,
> No problem.
Thank you.
> Peter
/Jarkko
next prev parent reply other threads:[~2014-12-14 15:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 19:46 [PATCH v10 0/8] TPM 2.0 support Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 1/8] tpm: merge duplicate transmit_cmd() functions Jarkko Sakkinen
2014-12-14 14:03 ` Stefan Berger
2014-12-14 14:57 ` Jarkko Sakkinen
2014-12-14 15:31 ` peterhuewe
2014-12-14 15:42 ` Jarkko Sakkinen [this message]
2014-12-12 19:46 ` [PATCH v10 2/8] tpm: two-phase chip management functions Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 3/8] tpm: fix raciness of PPI interface lookup Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 4/8] tpm: rename chip->dev to chip->pdev Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 5/8] tpm: device class for tpm Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 6/8] tpm: TPM 2.0 baseline support Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 7/8] tpm: TPM 2.0 CRB Interface Jarkko Sakkinen
2014-12-12 19:46 ` [PATCH v10 8/8] tpm: TPM 2.0 FIFO Interface Jarkko Sakkinen
2014-12-14 14:48 ` Stefan Berger
2014-12-14 15:40 ` Jarkko Sakkinen
2014-12-14 16:09 ` Stefan Berger
2014-12-14 18:27 ` Scot Doyle
2014-12-14 20:40 ` Stefan Berger
2014-12-14 23:13 ` Jarkko Sakkinen
2014-12-13 17:53 ` [tpmdd-devel] [PATCH v10 0/8] TPM 2.0 support Scot Doyle
2014-12-14 14:56 ` Jarkko Sakkinen
2014-12-15 20:17 ` Jarkko Sakkinen
2014-12-16 21:19 ` Aw: " Peter Huewe
2014-12-16 21:31 ` Jarkko Sakkinen
[not found] ` <trinity-c704c9fe-b92f-48bd-80cc-a452bd18cc28-1418765537847@3capp-gmx-bs15>
2014-12-16 21:34 ` Re: [tpmdd-devel] " Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141214154233.GA14110@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ashley@ashleylai.com \
--cc=christophe.ricard@gmail.com \
--cc=jason.gunthorpe@obsidianresearch.com \
--cc=josh@joshtriplett.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=trousers-tech@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome