From: Peter Zijlstra <peterz@infradead.org>
To: kan.liang@intel.com
Cc: linux-kernel@vger.kernel.org, ak@linux.intel.com
Subject: Re: [PATCH 1/1] perf, x86: bug fix for cycles:p and cycles:pp on SLM
Date: Mon, 15 Dec 2014 16:21:50 +0100 [thread overview]
Message-ID: <20141215152150.GB29390@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1418048863-4294-1-git-send-email-kan.liang@intel.com>
On Mon, Dec 08, 2014 at 06:27:43AM -0800, kan.liang@intel.com wrote:
> +++ b/arch/x86/kernel/cpu/perf_event_intel_ds.c
> @@ -568,8 +568,8 @@ struct event_constraint intel_atom_pebs_event_constraints[] = {
> };
>
> struct event_constraint intel_slm_pebs_event_constraints[] = {
> - /* UOPS_RETIRED.ALL, inv=1, cmask=16 (cycles:p). */
> - INTEL_FLAGS_EVENT_CONSTRAINT(0x108001c2, 0xf),
> + /* INST_RETIRED.ANY_P */
> + INTEL_UEVENT_CONSTRAINT(0x00c0, 0x1),
Should that not be:
INTEL_FLAGS_EVENT_CONSTRAINT(0x108000c0, 0x1),
instead?
> /* Allow all events as PEBS with no flags */
> INTEL_ALL_EVENT_CONSTRAINT(0, 0x1),
> EVENT_CONSTRAINT_END
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2014-12-15 15:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 14:27 kan.liang
2014-12-15 15:18 ` Peter Zijlstra
2014-12-15 15:21 ` Peter Zijlstra [this message]
2014-12-22 13:34 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215152150.GB29390@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®