From: "David Lanzendörfer" <david.lanzendoerfer@o2s.ch>
To: "Ulf Hansson" <ulf.hansson@linaro.org>,
"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-mmc@vger.kernel.org, "Chris Ball" <chris@printf.net>,
linux-kernel@vger.kernel.org,
"Peter Griffin" <peter.griffin@linaro.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"David Lanzendörfer" <david.lanzendoerfer@o2s.ch>,
李想 <lixiang@allwinnertech.com>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] mmc: sunxi: Correcting SDXC_HARDWARE_RESET bit
Date: Tue, 16 Dec 2014 15:11:10 +0100 [thread overview]
Message-ID: <20141216141110.3036.2534.stgit@dizzy-6.o2s.ch> (raw)
In-Reply-To: <20141216140921.3036.14668.stgit@dizzy-6.o2s.ch>
Fixing the register name in sunxi_mmc_reset_host since the SDXC_HARDWARE_RESET bit
is actually located within REG_GCTRL and not REG_CMDR as it was pointed out by Allwinner.
Signed-off-by: David Lanzendörfer <david.lanzendoerfer@o2s.ch>
Reported-by: 李想 <lixiang@allwinnertech.com>
---
drivers/mmc/host/sunxi-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index 67e680c..695fe85 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -252,7 +252,7 @@ static int sunxi_mmc_reset_host(struct sunxi_mmc_host *host)
unsigned long expire = jiffies + msecs_to_jiffies(250);
u32 rval;
- mmc_writel(host, REG_CMDR, SDXC_HARDWARE_RESET);
+ mmc_writel(host, REG_GCTRL, SDXC_HARDWARE_RESET);
do {
rval = mmc_readl(host, REG_GCTRL);
} while (time_before(jiffies, expire) && (rval & SDXC_HARDWARE_RESET));
next prev parent reply other threads:[~2014-12-16 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 14:10 [PATCH 0/4] mmc: sunxi: General fixup (v2) David Lanzendörfer
2014-12-16 14:10 ` [PATCH 1/4] mmc: sunxi: Fix setup of last descriptor of dma transfer David Lanzendörfer
2014-12-16 14:11 ` [PATCH 2/4] mmc: sunxi: Lock fix David Lanzendörfer
2014-12-16 14:11 ` David Lanzendörfer [this message]
2014-12-16 14:11 ` [PATCH 4/4] mmc: sunxi: Removing unused code David Lanzendörfer
2014-12-16 14:12 ` [PATCH 0/4] mmc: sunxi: General fixup (v2) Hans de Goede
2014-12-19 12:32 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216141110.3036.2534.stgit@dizzy-6.o2s.ch \
--to=david.lanzendoerfer@o2s.ch \
--cc=arnd@arndb.de \
--cc=chris@printf.net \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lixiang@allwinnertech.com \
--cc=maxime.ripard@free-electrons.com \
--cc=peter.griffin@linaro.org \
--cc=tomeu.vizoso@collabora.com \
--cc=ulf.hansson@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®