From: "Lennart Sorensen" <lsorense@csclub.uwaterloo.ca>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, "Kristo,
Tero" <t-kristo@ti.com>, Nishanth Menon <nm@ti.com>,
Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH 2/2] ARM: omap5/dra7xx: Fix counter frequency drift for AM572x errata i856.
Date: Tue, 16 Dec 2014 11:16:14 -0500 [thread overview]
Message-ID: <20141216161614.GK24110@csclub.uwaterloo.ca> (raw)
In-Reply-To: <549018EC.8020207@ti.com>
On Tue, Dec 16, 2014 at 05:05:08PM +0530, Lokesh Vutla wrote:
> Is this applicable for OMAP5 also?
> If not can you drop omap5 from $subject?
DRA7xx = OMAP57xx, which to me is an omap5. Isn't it?
And I haven't been able to get a manual for the omap54xx to confirm it,
although it seems it does not apply to the omap54xx from what I have
been able to gather indirectly.
arch_timer_freq = (rate / den) * num;
If I do this with the workaround I get:
20000000 / 75 * 244 = 6147525
where as
20000000 * 244 / 75 = 6147540
best value would be 6147541 with proper rounding.
In the normal case the worst case is:
26000000 * 384 = 9984000000
That is too big for 32 bits.
Now what could be done is prescale by 4 to make the worst case still
fit in 32 bits while doing the multiplication before the division,
so like this:
arch_timer_freq = ((rate / 4) * num / den ) * 4;
That gives the same result in all cases including the errata case for
the dra7xx at 20MHz and 27MHz. It is off by 3 in the 19.2MHz case though
which isn't so nice.
Would that be more acceptable? I think having the arch_timer_freq
calculated for the errata case seperately from the normal case is
cleaner looking compared to that mess and gives a better result for the
19.2MHz case.
--
Len Sorensen
next prev parent reply other threads:[~2014-12-16 16:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 22:08 [PATCH 0/2] ARM: omap5/dra7xx counter frequency fixes Lennart Sorensen
2014-12-12 22:08 ` [PATCH 1/2] ARM: omap5/dra7xx: Fix frequency typos Lennart Sorensen
2014-12-16 11:38 ` Lokesh Vutla
2014-12-16 14:06 ` Nishanth Menon
2014-12-16 16:39 ` Lennart Sorensen
2014-12-12 22:08 ` [PATCH 2/2] ARM: omap5/dra7xx: Fix counter frequency drift for AM572x errata i856 Lennart Sorensen
2014-12-14 4:45 ` Lennart Sorensen
2014-12-16 11:35 ` Lokesh Vutla
2014-12-16 14:58 ` Nishanth Menon
2014-12-16 16:36 ` Lennart Sorensen
2014-12-16 18:59 ` Nishanth Menon
2014-12-16 19:27 ` Lennart Sorensen
2014-12-16 19:33 ` Nishanth Menon
2014-12-17 13:21 ` Tero Kristo
2014-12-17 14:55 ` Lennart Sorensen
2014-12-17 15:22 ` Nishanth Menon
2014-12-17 15:27 ` Lennart Sorensen
2014-12-17 15:45 ` Tero Kristo
2014-12-17 15:49 ` Lennart Sorensen
2014-12-17 15:53 ` Nishanth Menon
2014-12-17 15:56 ` Tero Kristo
2014-12-16 16:16 ` Lennart Sorensen [this message]
2014-12-16 19:56 ` Nishanth Menon
2014-12-16 19:58 ` Lennart Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216161614.GK24110@csclub.uwaterloo.ca \
--to=lsorense@csclub.uwaterloo.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®