From: Andrew Lunn <andrew@lunn.ch>
To: Evgeni Dobrev <evgeni@studio-punkt.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>,
linux-kernel@vger.kernel.org,
Gregory Clement <gregory.clement@free-electrons.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: kirkwood: add dts support for Seagate BlackArmor NAS220
Date: Tue, 16 Dec 2014 20:20:20 +0100 [thread overview]
Message-ID: <20141216192020.GB12820@lunn.ch> (raw)
In-Reply-To: <20141216163714.GE20170@anne>
> The LED can be either one of the two colors or off. Swapping the
> polarity on the two LED pins changes the color.
O.K, so it is using the diode property of a Light Emitting Diode, to
support two colours.
> I am currently playing with the idea to create a multicolor LED kernel
> driver which is being controlled via GPIOs, but I still have not found
> the proper abstraction for it.
Maybe multi-colour is too far. Just support bi-colour via two gpios.
Still, it is not so simple. As you said, the led class does not give
too good an abstraction. I guess the best you can do is that when you
turn one on, it automagically turns the other off.
> The point is, that even though this functionality must currently be
> handled by user space (some combination of sysfs writes and a shell
> script) at the moment, the rest of the system is usable.
Sure, we will take the DT file without support for the bicolour
LED. It can be added later.
Andrew
next prev parent reply other threads:[~2014-12-16 19:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 20:38 Evgeni Dobrev
2014-12-16 8:56 ` Andrew Lunn
2014-12-16 16:37 ` Evgeni Dobrev
2014-12-16 19:20 ` Andrew Lunn [this message]
2014-12-22 8:04 ` [PATCH v2 0/1] add " Evgeni Dobrev
2014-12-22 8:04 ` [PATCH v2 1/1] " Evgeni Dobrev
2014-12-22 10:02 ` Andrew Lunn
2014-12-22 12:57 ` [PATCH v3 0/1] " Evgeni Dobrev
2014-12-22 12:57 ` [PATCH v3 1/1] " Evgeni Dobrev
2014-12-23 11:31 ` Andrew Lunn
2014-12-25 13:08 ` Sebastian Hesselbarth
2014-12-25 13:31 ` Andrew Lunn
2014-12-25 13:43 ` Sebastian Hesselbarth
2014-12-25 14:12 ` Andrew Lunn
2014-12-25 15:19 ` Sebastian Hesselbarth
2014-12-26 11:06 ` Evgeni Dobrev
2014-12-28 10:46 ` [PATCH v4 0/1] " Evgeni Dobrev
2014-12-28 10:46 ` [PATCH v4 1/1] " Evgeni Dobrev
2015-01-05 18:05 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216192020.GB12820@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=evgeni@studio-punkt.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®