Re: [PATCH 10/18] tools lib: Move asm-generic/bitops/find.h code to tools/include and tools/lib

[Jiri Olsa <jolsa@redhat.com>]

On Tue, Dec 16, 2014 at 01:57:12PM -0300, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> To match the Linux kernel source code structure from where this code came from.

SNIP

> +			goto found;
> +		result += BITS_PER_LONG;
> +		size -= BITS_PER_LONG;
> +	}
> +	if (!size)
> +		return result;
> +
> +	tmp = (*p) & (~0UL >> (BITS_PER_LONG - size));
> +	if (tmp == 0UL)		/* Are any bits set? */
> +		return result + size;	/* Nope. */
> +found:
> +	return result + __ffs(tmp);
> +}
> +#endif
> diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST
> index 67d48e20f7e1..bfd7e22bafad 100644
> --- a/tools/perf/MANIFEST
> +++ b/tools/perf/MANIFEST
> @@ -4,8 +4,10 @@ tools/lib/traceevent
>  tools/lib/api
>  tools/lib/symbol/kallsyms.c
>  tools/lib/symbol/kallsyms.h
> +tools/lib/util/find_next_bit.c

hum, I had the impression that we will move 'generic' things under 'api' to
be built separatelly.. so whats the current notion? ;-)

what kind of code belongs to 'lib/api/...' and what to 'lib/...' ?

thanks,
jirka