From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751273AbaLQPpm (ORCPT ); Wed, 17 Dec 2014 10:45:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53719 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbaLQPpl (ORCPT ); Wed, 17 Dec 2014 10:45:41 -0500 Date: Wed, 17 Dec 2014 16:45:07 +0100 From: Jiri Olsa To: Peter Zijlstra Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , Steven Rostedt , Linus Torvalds Subject: Re: [PATCH] perf: Avoid horrible stack usage Message-ID: <20141217154507.GA20471@krava.brq.redhat.com> References: <20141216115041.GW3337@twins.programming.kicks-ass.net> <20141217143105.GG18257@krava.brq.redhat.com> <20141217153508.GC30905@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141217153508.GC30905@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 17, 2014 at 04:35:08PM +0100, Peter Zijlstra wrote: > On Wed, Dec 17, 2014 at 03:31:05PM +0100, Jiri Olsa wrote: > > looks like we could also sanitize the perf_ftrace_function_call > > in the same way.. like below (untested) > > > > hum, I just noticed it actually has pt_regs arg ;-) > > Bu if it has pt_regs should we not use that instead of filling one out > again? yep, I talked to Steven about that and the thing is that it's not guaranteed on all archs.. I'll send patch that take that in account jirka