From: Tsung-Han Lin <tsunghan.tw@gmail.com>
To: Grant Likely <grant.likely@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:board: fix build errors and warnings
Date: Thu, 18 Dec 2014 02:07:56 +0800 [thread overview]
Message-ID: <20141217180756.GA23742@Tari7Braves> (raw)
In-Reply-To: <20141212113610.C88F5C40872@trevor.secretlab.ca>
On Fri, Dec 12, 2014 at 11:36:10AM +0000, Grant Likely wrote:
> On Tue, 9 Dec 2014 01:24:09 +0800
> , Tsung-Han Lin <tsunghan.tw@gmail.com>
> wrote:
> > Add dummy implementation of 'of_find_all_nodes',
> > and remove the unnecessary 'of_can_translate_address',
> > which is already removed in commit
> > d9c6866be8a145e32da616d8dcbae806032d75b5 ("of: kill off
> > of_can_translate_address"), to fix the build errors and warnings
> > found by sparse.
> >
> > Signed-off-by: Tsung-Han Lin <tsunghan.tw@gmail.com>
>
> ???
>
> This code is just weird. If CONFIG_OF is not enabled, then board.c
> shouldn't be compiled at all. You can do this with a patch to the
> Kconfig and Makefile. Also, if the functions in
> drivers/staging/board/board.c are needed for driver support, then please
> propose a patch that moves them in into drivers/of/base.c so that they
> can be reviewed properly. They are so short and simple that fixing them
> up as part of the normal review process should be sufficient.
>
> As for fixing the compile error, please drop the change to
> include/linux/of.h and resubmit.
>
> g.
>
>
Sorry it took me sometime to understand what I got wrong,
and thank you for your suggestion.
I will re-send a fix for this.
I just built those codes with wrong .config and options.
prev parent reply other threads:[~2014-12-17 18:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 17:24 Tsung-Han Lin
2014-12-12 11:36 ` Grant Likely
2014-12-17 18:07 ` Tsung-Han Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141217180756.GA23742@Tari7Braves \
--to=tsunghan.tw@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®