From: David Miller <davem@davemloft.net>
To: andreas@gaisler.com
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
software@gaisler.com
Subject: Re: [PATCH] sparc32: destroy_context() and switch_mm() needs to disable interrupts.
Date: Thu, 18 Dec 2014 12:48:11 -0500 (EST) [thread overview]
Message-ID: <20141218.124811.1240082913671950177.davem@davemloft.net> (raw)
In-Reply-To: <1418905403-11154-1-git-send-email-andreas@gaisler.com>
From: Andreas Larsson <andreas@gaisler.com>
Date: Thu, 18 Dec 2014 13:23:23 +0100
> Load balancing can be triggered in the critical sections protected by
> srmmu_context_spinlock in destroy_context() and switch_mm() and can hang
> the cpu waiting for the rq lock of another cpu that in turn has called
> switch_mm hangning on srmmu_context_spinlock leading to deadlock.
>
> So, disable interrupt while taking srmmu_context_spinlock in
> destroy_context() and switch_mm() so we don't deadlock.
>
> See also commit 77b838fa1ef0 ("[SPARC64]: destroy_context() needs to disable
> interrupts.")
>
> Signed-off-by: Andreas Larsson <andreas@gaisler.com>
Looks good, applied, thanks Andreas.
prev parent reply other threads:[~2014-12-18 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 12:23 Andreas Larsson
2014-12-18 17:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218.124811.1240082913671950177.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andreas@gaisler.com \
--cc=linux-kernel@vger.kernel.org \
--cc=software@gaisler.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®