On Wed, Dec 17, 2014 at 05:03:22PM +0300, Dan Carpenter wrote: > On Wed, Dec 17, 2014 at 04:43:54PM +0300, samuel kihahu wrote: > > On Wed, Dec 17, 2014 at 03:11:19PM +0300, Dan Carpenter wrote: > > > On Wed, Dec 17, 2014 at 02:56:02PM +0300, samuel kihahu wrote: > > > > Replacing obsolete simple_strtoul with kstrtoul. > > > > > > > > > > Nope. That's wrong. Learn how the functions are different beyond just > > > the name. > > Noted, have made corrections to fit the kstrtoul and handle the return > > value. > > You have to compile test these things. Really kernel programming is not > a good way to learn how to program. :( > > regards, > dan carpenter > Appreciate the feedback, have modified the patch, tested and confirmed it builds.