From: Jiri Olsa <jolsa@redhat.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools: perf: util: color.c: Remove some unused functions
Date: Mon, 22 Dec 2014 15:56:10 +0100 [thread overview]
Message-ID: <20141222145610.GD29096@krava.brq.redhat.com> (raw)
In-Reply-To: <1419079865-354-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sat, Dec 20, 2014 at 01:51:05PM +0100, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> color_parse_mem() color_parse()
>
> This was partially found by using a static code analysis program called cppcheck.
and partially removed ;-)
[jolsa@krava perf]$ make
BUILD: Doing 'make -j4' parallel build
CC util/debug.o
CC util/color.o
CC util/machine.o
CC util/map.o
util/color.c:8:12: error: ‘parse_color’ defined but not used [-Werror=unused-function]
static int parse_color(const char *name, int len)
^
util/color.c:28:12: error: ‘parse_attr’ defined but not used [-Werror=unused-function]
static int parse_attr(const char *name, int len)
^
cc1: all warnings being treated as errors
make[1]: *** [util/color.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2
any clue why this (color name parsing) is in?
thanks,
jirka
next prev parent reply other threads:[~2014-12-22 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 12:51 Rickard Strandqvist
2014-12-22 14:50 ` Arnaldo Carvalho de Melo
2014-12-22 14:53 ` Arnaldo Carvalho de Melo
2014-12-22 14:56 ` Arnaldo Carvalho de Melo
2014-12-22 14:56 ` Jiri Olsa [this message]
2014-12-22 15:05 ` Arnaldo Carvalho de Melo
2014-12-22 15:13 ` Arnaldo Carvalho de Melo
2015-01-28 15:05 ` [tip:perf/core] perf tools: Remove some unused functions from color.c tip-bot for Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141222145610.GD29096@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=artagnon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome