From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755429AbaLVReU (ORCPT ); Mon, 22 Dec 2014 12:34:20 -0500 Received: from cantor2.suse.de ([195.135.220.15]:58454 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754481AbaLVReS (ORCPT ); Mon, 22 Dec 2014 12:34:18 -0500 Date: Mon, 22 Dec 2014 18:34:09 +0100 From: Petr Mladek To: Josh Poimboeuf Cc: Masami Hiramatsu , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Steven Rostedt , Miroslav Benes , Christoph Hellwig , Greg KH , Andy Lutomirski , live-patching@vger.kernel.org, x86@kernel.org, kpatch@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] livepatch: use FTRACE_OPS_FL_IPMODIFY Message-ID: <20141222173409.GC2494@dhcp128.suse.cz> References: <1418752700-14649-1-git-send-email-sjenning@redhat.com> <5492C0A9.3080303@hitachi.com> <20141218154935.GA6887@treble.redhat.com> <20141219094335.GA9571@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141219094335.GA9571@pathway.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2014-12-19 10:43:35, Petr Mladek wrote: > On Thu 2014-12-18 09:49:35, Josh Poimboeuf wrote: > > On Thu, Dec 18, 2014 at 08:55:21PM +0900, Masami Hiramatsu wrote: > > > (2014/12/17 2:58), Seth Jennings wrote: > > > > changes in v7: > > > > - TODO: set IPMODIFY (not a blocker to moving forward) > > > > > > Why don't you set this? > > > IPMODIFY series are not completely applied yet, but you can already > > > use the flag. All you need is just set it :) > > > > Yeah, I don't see any reason why we can't start using this flag now. > > How about we add this patch to the queue? > > > > -->8-- > > > > Subject: livepatch: use FTRACE_OPS_FL_IPMODIFY > > > > Use the FTRACE_OPS_FL_IPMODIFY flag to prevent conflicts with other > > ftrace users who also modify regs->ip. > > > > Signed-off-by: Josh Poimboeuf > > It makes sense. The flag is available even in 3.19. > > Reviewed-by: Petr Mladek Feel free to keep the Reviewed-by if you fix the typo, see below. > > --- > > kernel/livepatch/core.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c > > index 0004a71..bdd99975 100644 > > --- a/kernel/livepatch/core.c > > +++ b/kernel/livepatch/core.c > > @@ -640,7 +640,8 @@ static int klp_init_func(struct klp_object *obj, struct klp_func *func) > > > > ops->private = func; > > ops->func = klp_ftrace_handler; > > - ops->flags = FTRACE_OPS_FL_SAVE_REGS | FTRACE_OPS_FL_DYNAMIC; > > + ops->flags = FTRACE_OPS_FL_SAVE_REGS | FTRACE_OPS_FL_DYNAMIC | > > + FTRACE_FL_IPMODIFY; Heh, there is a typo. Please replace FTRACE_FL_IPMODIFY with FTRACE_OPS_FL_IPMODIFY ;-) Best Regards, Petr > > func->fops = ops; > > func->state = KLP_DISABLED; > > > > -- > > 2.1.0 > > > -- > To unsubscribe from this list: send the line "unsubscribe live-patching" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html