From: Mark Brown <broonie@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] spi: Add new driver for STMicroelectronics' SPI Controller
Date: Mon, 22 Dec 2014 18:36:22 +0000 [thread overview]
Message-ID: <20141222183622.GI17800@sirena.org.uk> (raw)
In-Reply-To: <1418156491-26613-2-git-send-email-lee.jones@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Tue, Dec 09, 2014 at 08:21:30PM +0000, Lee Jones wrote:
> This patch adds support for the SPI portion of ST's SSC device.
I've applied both of these, though I had to rename the DT binding
document and...
> +static int spi_st_clk_enable(struct spi_st *spi_st)
> +{
> + /*
> + * Current platforms use one of the core clocks for SPI and I2C.
> + * If we attempt to disable the clock, the system will hang.
> + *
> + * TODO: Remove this when platform supports power domains.
> + */
> + return 0;
> +
> + return clk_prepare_enable(spi_st->clk);
> +}
...this is not good at all and a step back from the previous version -
if there are problems with the SoC integration they need to be fixed
there or possibly in the clock driver for the SoC rather than bodging
individual drivers.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-12-22 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 20:21 [PATCH v4 0/2] spi: st: New driver for ST's " Lee Jones
2014-12-09 20:21 ` [PATCH v4 1/2] spi: Add new driver for STMicroelectronics' " Lee Jones
2014-12-22 18:36 ` Mark Brown [this message]
2014-12-09 20:21 ` [PATCH v4 2/2] spi: st: Provide Device Tree binding documentation Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141222183622.GI17800@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®