mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremiah Mahler <jmmahler@gmail.com>
To: samuel kihahu <skihahu@gmail.com>
Cc: gregkh@linuxfoundation.org, oleg.drokin@intel.com,
	andreas.dilger@intel.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: cleanup align switch and case
Date: Tue, 23 Dec 2014 01:36:54 -0800	[thread overview]
Message-ID: <20141223093654.GA5208@hudson.localdomain> (raw)
In-Reply-To: <1419321466-8068-1-git-send-email-skihahu@gmail.com>

samuel,

This patch is corrupt and won't apply.  I suspect it is due to missing
spaces at the start of each line in the diff.

I recommend using 'git send-email'.  But if you are using a different
client have a look at Documentation/email-clients.txt for tips on how to
avoid these problems.

On Tue, Dec 23, 2014 at 10:57:46AM +0300, samuel kihahu wrote:
> From: samuel kihahu <skihahu@gmail.com>
> 
> Align switch and case to be at the same indent.
> 
> Signed-off-by: samuel kihahu <skihahu@gmail.com>
> ---
>  drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
>  1 file changed, 25 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
> index 6dd4309..b5f07fa 100644
> --- a/drivers/staging/lustre/lnet/selftest/module.c
> +++ b/drivers/staging/lustre/lnet/selftest/module.c
> @@ -61,31 +61,31 @@ lnet_selftest_fini(void)
> 	int	i;
> 
> 	switch (lst_init_step) {
> -		case LST_INIT_CONSOLE:
> -			lstcon_console_fini();
> -		case LST_INIT_FW:
> -			sfw_shutdown();
> -		case LST_INIT_RPC:
> -			srpc_shutdown();
> -		case LST_INIT_WI_TEST:
> -			for (i = 0;
> -			     i < cfs_cpt_number(lnet_cpt_table()); i++) {
> -				if (lst_sched_test[i] == NULL)
> -					continue;
> -				cfs_wi_sched_destroy(lst_sched_test[i]);
> -			}
> -			LIBCFS_FREE(lst_sched_test,
> -				    sizeof(lst_sched_test[0]) *
> -				    cfs_cpt_number(lnet_cpt_table()));
> -			lst_sched_test = NULL;
> -
> -		case LST_INIT_WI_SERIAL:
> -			cfs_wi_sched_destroy(lst_sched_serial);
> -			lst_sched_serial = NULL;
> -		case LST_INIT_NONE:
> -			break;
> -		default:
> -			LBUG();
> +	case LST_INIT_CONSOLE:
> +		lstcon_console_fini();
> +	case LST_INIT_FW:
> +		sfw_shutdown();
> +	case LST_INIT_RPC:
> +		srpc_shutdown();
> +	case LST_INIT_WI_TEST:
> +		for (i = 0;
> +		     i < cfs_cpt_number(lnet_cpt_table()); i++) {
> +			if (lst_sched_test[i] == NULL)
> +				continue;
> +			cfs_wi_sched_destroy(lst_sched_test[i]);
> +		}
> +		LIBCFS_FREE(lst_sched_test,
> +			    sizeof(lst_sched_test[0]) *
> +			    cfs_cpt_number(lnet_cpt_table()));
> +		lst_sched_test = NULL;
> +
> +	case LST_INIT_WI_SERIAL:
> +		cfs_wi_sched_destroy(lst_sched_serial);
> +		lst_sched_serial = NULL;
> +	case LST_INIT_NONE:
> +		break;
> +	default:
> +		LBUG();
> 	}
> 	return;
>  }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
- Jeremiah Mahler

  parent reply	other threads:[~2014-12-23  9:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-23  7:57 samuel kihahu
2014-12-23  8:54 ` Dan Carpenter
2014-12-23  9:36 ` Jeremiah Mahler [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-12-23 12:04 samuel kihahu
2014-12-22 20:48 samuel kihahu
2014-12-22 21:18 ` Greg KH
2014-12-23  4:38   ` samuel kihahu
2014-12-23  5:58     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141223093654.GA5208@hudson.localdomain \
    --to=jmmahler@gmail.com \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    --cc=skihahu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®